-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WW-5339 Add option to block custom OGNL maps #806
Conversation
if (resolver == null) { | ||
resolver = container.getInstance(CompoundRootAccessor.class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This didn't work :(
1a13187
to
002e598
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, could you document another security option ? Thanks!
@lukaszlenart |
Just tested the Showcase app and it doesn't look good ;-)
|
WW-5339
Having consulted with a security researcher - there is still some risk here if there exists a custom map implementation whose
java.util.Map
methods pose some risk. This is becauseognl.MapPropertyAccessor#getProperty
does not consult theMemberAccess
policy for the inherentjava.util.Map
methods.Given Struts does not rely on custom OGNL Map implementations, we should add an option to block this capability.