Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase struts-7-0-x branch #809

Merged
merged 13 commits into from
Dec 17, 2023
Merged

Conversation

lukaszlenart
Copy link
Member

Rebases struts-7-0-x branch to be up to date with the master branch.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

52.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@kusalk
Copy link
Member

kusalk commented Dec 17, 2023

The diff for this PR is confusing me - it seems like some of the changes from my PRs (#800 and #806) are already present on the 7.0 branch and some are in this PR?

Anyway, I trust you know what you're doing so go ahead and merge this - but I usually avoid rebasing and rewriting history for release branches (or any long-living branch) because resolving conflicts can become cumbersome and complex, and it's often harder to revert back to a previous state in case of a mistaken push or change

I find it simpler to use merge commits as I did in #797 - I created that PR as follows:

git checkout release/struts-7-0-x
git pull
git checkout -b merge-master-to-70-2024-12-17
git merge origin/master

And then I created a PR from merge-master-to-70-2024-12-17 targeting release/struts-7-0-x.

Just an alternative approach you might find easier in the future :)

@lukaszlenart
Copy link
Member Author

I rebased release/struts-7-0-x but looks like I missed something during that process, that's why I created the PR with all the missing parts

@kusalk
Copy link
Member

kusalk commented Dec 17, 2023

All good then :)

@lukaszlenart lukaszlenart merged commit cd2bfee into release/struts-7-0-x Dec 17, 2023
6 of 7 checks passed
@lukaszlenart lukaszlenart deleted the fix/after-rebase branch December 17, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants