-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase struts-7-0-x branch #809
Conversation
Quality Gate failedFailed conditions 52.6% Coverage on New Code (required ≥ 80%) |
The diff for this PR is confusing me - it seems like some of the changes from my PRs (#800 and #806) are already present on the 7.0 branch and some are in this PR? Anyway, I trust you know what you're doing so go ahead and merge this - but I usually avoid rebasing and rewriting history for release branches (or any long-living branch) because resolving conflicts can become cumbersome and complex, and it's often harder to revert back to a previous state in case of a mistaken push or change I find it simpler to use merge commits as I did in #797 - I created that PR as follows:
And then I created a PR from Just an alternative approach you might find easier in the future :) |
I rebased |
All good then :) |
Rebases struts-7-0-x branch to be up to date with the master branch.