Fix CREATE_DATASET_TEXT and tooltip in footer, add todo note to histo…

…ry functionality in DatabaseModal
apache · Feb 1, 2023 · e80adab · e80adab
1 parent 4bafc1a
commit e80adab
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
@@ -656,6 +656,8 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
   };
 
   const redirectURL = (url: string) => {
+    /* TODO (lyndsiWilliams): This check and passing history
+      as a prop can be removed once SQL Lab is in the SPA */
     if (!isEmpty(history)) {
       history?.push(url);
     } else {

diff --git a/superset-frontend/src/views/CRUD/data/dataset/AddDataset/Footer/index.tsx b/superset-frontend/src/views/CRUD/data/dataset/AddDataset/Footer/index.tsx
@@ -106,7 +106,7 @@ function Footer({
     }
   };
 
-  const CREATE_DATASET_TEXT = t('Create Dataset and Create Chart');
+  const CREATE_DATASET_TEXT = t('Create dataset and create chart');
   const disabledCheck =
     !datasetObject?.table_name ||
     !hasColumns ||

diff --git a/superset-frontend/src/views/CRUD/data/dataset/styles.ts b/superset-frontend/src/views/CRUD/data/dataset/styles.ts
@@ -62,6 +62,7 @@ export const PanelRow = styled(Row)`
 export const FooterRow = styled(Row)`
   flex: 0 0 auto;
   height: ${({ theme }) => theme.gridUnit * 16}px;
+  z-index: 0;
 `;
 
 export const StyledLayoutHeader = styled.div`