Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tests errors and warnings - iteration 6 (#12212) #12227

Merged

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Dec 30, 2020

SUMMARY

Remove tests errors and warnings to improve results readability.

The following errors and warnings have been removed:

Warning: Failed prop type: The prop `onClick` is marked as required, 
but its value is `undefined`.

spec/javascripts/sqllab/ExploreResultsButton_spec.jsx
Warning: Failed prop type: The prop `displayLimit` is marked as required, 
but its value is `undefined`.

spec/javascripts/sqllab/QueryTable_spec.jsx
spec/javascripts/sqllab/TabbedSqlEditors_spec.jsx
Unmatched <HTTP_METHOD> to <URL>

spec/javascripts/sqllab/TabbedSqlEditors_spec.jsx
spec/javascripts/views/CRUD/chart/ChartList_spec.jsx
spec/javascripts/views/CRUD/dashboard/DashboardList_spec.jsx
spec/javascripts/views/CRUD/welcome/ChartTable_spec.tsx
spec/javascripts/views/CRUD/welcome/SavedQueries_spec.tsx
When testing, code that causes React state updates should be wrapped into act(...)

spec/javascripts/sqllab/TabbedSqlEditors_spec.jsx
spec/javascripts/views/CRUD/chart/ChartList_spec.jsx
spec/javascripts/views/CRUD/dashboard/DashboardList_spec.jsx
spec/javascripts/views/CRUD/welcome/ChartTable_spec.tsx
spec/javascripts/views/CRUD/welcome/DashboardTable_spec.tsx
Warning: Failed prop type: The prop `tabState` is marked as required, 
but its value is `undefined`.

spec/javascripts/sqllab/TabbedSqlEditors_spec.jsx
Error: fetch-mock: No fallback response defined for <HTTP_METHOD> to <URL>

spec/javascripts/views/CRUD/chart/ChartList_spec.jsx
spec/javascripts/views/CRUD/welcome/ChartTable_spec.tsx
spec/javascripts/views/CRUD/welcome/SavedQueries_spec.tsx
Deprecation warning: value provided is not in a recognized RFC2822 or ISO format. 
moment construction falls back to js Date(), which is not reliable across all browsers and versions. 
Non RFC2822/ISO date formats are discouraged.

src/views/CRUD/welcome/ActivityTable.tsx

#12212

@rusackas @junlincc @villebro

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Jan 20, 2021

Codecov Report

Merging #12227 (532efa4) into master (a422c76) will decrease coverage by 0.28%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12227      +/-   ##
==========================================
- Coverage   66.79%   66.51%   -0.29%     
==========================================
  Files        1015     1017       +2     
  Lines       49676    49734      +58     
  Branches     4847     4864      +17     
==========================================
- Hits        33183    33079     -104     
- Misses      16371    16533     +162     
  Partials      122      122              
Flag Coverage Δ
cypress 50.99% <28.00%> (-0.06%) ⬇️
javascript 60.90% <75.00%> (+0.15%) ⬆️
python 63.47% <ø> (-0.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/common/components/index.tsx 100.00% <ø> (ø)
...ard/components/nativeFilters/FilterConfigModal.tsx 62.80% <ø> (-0.23%) ⬇️
...nd/src/dashboard/components/nativeFilters/types.ts 100.00% <ø> (ø)
superset-frontend/src/dashboard/reducers/types.ts 0.00% <0.00%> (ø)
...-frontend/src/views/CRUD/welcome/ActivityTable.tsx 65.51% <ø> (ø)
...nd/src/dashboard/components/nativeFilters/utils.ts 62.96% <71.42%> (+5.06%) ⬆️
...dashboard/components/nativeFilters/FilterScope.tsx 76.92% <76.92%> (ø)
...dashboard/components/nativeFilters/ScopingTree.tsx 81.81% <85.71%> (+4.04%) ⬆️
...oard/components/nativeFilters/FilterConfigForm.tsx 90.47% <100.00%> (+8.33%) ⬆️
...nd/src/dashboard/components/nativeFilters/state.ts 66.03% <100.00%> (+5.16%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2463215...532efa4. Read the comment docs.

@rusackas rusackas removed the hold! On hold label Jan 25, 2021
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit 20503f9 into apache:master Jan 26, 2021
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Jan 26, 2021
* master: (52 commits)
  docs: Updates to Superset Site for 1.0 (apache#12626)
  test(native-filters): scoping tree in native filters modal (apache#12655)
  Fix tests errors and warnings - iteration 3 (apache#12212) (apache#12219)
  Fix tests errors and warnings - iteration 5 (apache#12212) (apache#12224)
  Fix tests errors and warnings - iteration 6 (apache#12212) (apache#12227)
  feat(native-filters): apply scoping of native filters to dashboard (apache#12716)
  Fix tests errors and warnings - iteration 4 (apache#12212) (apache#12223)
  Fix tests errors and warnings - iteration 7 (apache#12212) (apache#12245)
  fix: missing select menu background (apache#12759)
  fix(explore): incorrect missing datasource condition (apache#12758)
  feat: default timepicker to last week when dataset is changed (apache#12609)
  feat(explore): allow opening charts with missing dataset (apache#12705)
  chore: upgrade Cypress to 6.2.1 (apache#12605)
  refactor(explore): Enhance Dataset and Control panel Collapse components (apache#12218)
  feat: Adding option to set_database_uri CLI command (apache#12740)
  docs: Fixed typo on line 348 (apache#12739)
  Fix tests errors and warnings - iteration 2 (apache#12212) (apache#12214)
  docs: Remove gatsby-plugin-offline (apache#12693)
  test: oracle engine spec (apache#12615)
  test: hive db engine spec (apache#12520)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants