Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tests errors and warnings - iteration 7 (#12212) #12245

Merged

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Jan 4, 2021

SUMMARY

Remove tests errors and warnings to improve results readability.

The following errors and warnings have been removed:

Unmatched <HTTP_METHOD> to <URL>

spec/javascripts/dashboard/components/PropertiesModal_spec.jsx
spec/javascripts/views/CRUD/welcome/Welcome_spec.tsx
The pseudo class ":nth-child" is potentially unsafe when doing server-side rendering. 
Try changing it to ":nth-of-type".

spec/javascripts/views/CRUD/welcome/Welcome_spec.tsx
When testing, code that causes React state updates should be wrapped into act(...)

spec/javascripts/views/CRUD/welcome/Welcome_spec.tsx
Warning: React does not recognize the `isReportEnabled` prop on a DOM element. 
If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase 
`isreportenabled` instead. If you accidentally passed it from a parent component, 
remove it from the DOM element.

src/views/CRUD/alert/components/AlertStatusIcon.tsx

#12212

@rusackas @junlincc @villebro

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@junlincc junlincc added the hold! On hold label Jan 7, 2021
@michael-s-molina michael-s-molina force-pushed the fix-tests-errors-warnings-7 branch from 50e3f7d to 91cb275 Compare January 20, 2021 14:10
@codecov-io
Copy link

codecov-io commented Jan 20, 2021

Codecov Report

Merging #12245 (91cb275) into master (a422c76) will decrease coverage by 3.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12245      +/-   ##
==========================================
- Coverage   66.79%   63.65%   -3.15%     
==========================================
  Files        1015      486     -529     
  Lines       49676    29984   -19692     
  Branches     4847        0    -4847     
==========================================
- Hits        33183    19087   -14096     
+ Misses      16371    10897    -5474     
+ Partials      122        0     -122     
Flag Coverage Δ
cypress ?
javascript ?
python 63.65% <ø> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset/db_engine_specs/hive.py 54.61% <0.00%> (-29.24%) ⬇️
superset/models/core.py 88.58% <0.00%> (-0.28%) ⬇️
...t-frontend/src/components/DynamicPlugins/index.tsx
superset-frontend/src/components/FaveStar.tsx
...nd/src/dashboard/components/FiltersBadge/index.tsx
...set-frontend/src/components/URLShortLinkButton.jsx
...d/util/logging/getLoadStatsPerTopLevelComponent.js
...nd/src/dashboard/util/getFilterScopeParentNodes.js
superset-frontend/src/components/ErrorBoundary.jsx
... and 512 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2463215...91cb275. Read the comment docs.

@rusackas rusackas removed the hold! On hold label Jan 25, 2021
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit 0fc9da6 into apache:master Jan 26, 2021
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Jan 26, 2021
* master: (52 commits)
  docs: Updates to Superset Site for 1.0 (apache#12626)
  test(native-filters): scoping tree in native filters modal (apache#12655)
  Fix tests errors and warnings - iteration 3 (apache#12212) (apache#12219)
  Fix tests errors and warnings - iteration 5 (apache#12212) (apache#12224)
  Fix tests errors and warnings - iteration 6 (apache#12212) (apache#12227)
  feat(native-filters): apply scoping of native filters to dashboard (apache#12716)
  Fix tests errors and warnings - iteration 4 (apache#12212) (apache#12223)
  Fix tests errors and warnings - iteration 7 (apache#12212) (apache#12245)
  fix: missing select menu background (apache#12759)
  fix(explore): incorrect missing datasource condition (apache#12758)
  feat: default timepicker to last week when dataset is changed (apache#12609)
  feat(explore): allow opening charts with missing dataset (apache#12705)
  chore: upgrade Cypress to 6.2.1 (apache#12605)
  refactor(explore): Enhance Dataset and Control panel Collapse components (apache#12218)
  feat: Adding option to set_database_uri CLI command (apache#12740)
  docs: Fixed typo on line 348 (apache#12739)
  Fix tests errors and warnings - iteration 2 (apache#12212) (apache#12214)
  docs: Remove gatsby-plugin-offline (apache#12693)
  test: oracle engine spec (apache#12615)
  test: hive db engine spec (apache#12520)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants