Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: apply capitalization guidelines - iteration 1 (#12343) #12447

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Apply capitalization guidelines defined in #12343.

@junlincc

TEST PLAN

Check if modified texts are following capitalization guidelines.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Jan 12, 2021

Codecov Report

Merging #12447 (e25d043) into master (078a8a1) will decrease coverage by 4.36%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12447      +/-   ##
==========================================
- Coverage   66.81%   62.44%   -4.37%     
==========================================
  Files        1015     1015              
  Lines       49544    49530      -14     
  Branches     5080     5080              
==========================================
- Hits        33102    30929    -2173     
- Misses      16312    18392    +2080     
- Partials      130      209      +79     
Flag Coverage Δ
cypress ?
javascript 60.75% <20.00%> (ø)
python 63.55% <ø> (-0.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/chart/chartAction.js 50.25% <ø> (-26.91%) ⬇️
...-frontend/src/common/components/common.stories.tsx 0.00% <ø> (ø)
superset-frontend/src/components/AnchorLink.jsx 83.33% <ø> (-12.50%) ⬇️
superset-frontend/src/components/OmniContainer.jsx 16.00% <ø> (-44.00%) ⬇️
...s/controls/DateFilterControl/DateFilterControl.tsx 19.09% <0.00%> (-66.37%) ⬇️
...components/controls/DateFilterControl/constants.ts 100.00% <ø> (ø)
...ore/components/controls/DateFilterControl/types.ts 100.00% <ø> (ø)
superset-frontend/src/explore/constants.js 100.00% <ø> (ø)
superset-frontend/src/explore/controls.jsx 26.82% <ø> (ø)
superset-frontend/src/components/EditableTitle.tsx 72.22% <100.00%> (-2.78%) ⬇️
... and 210 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 078a8a1...e25d043. Read the comment docs.

Copy link
Member

@junlincc junlincc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for once, i completely understand all the code changes, LGTM!

@adam-stasiak
Copy link
Contributor

looks good to me

@ktmud ktmud merged commit 6731cd0 into apache:master Jan 12, 2021
@ktmud
Copy link
Member

ktmud commented Jan 12, 2021

Oops, forgot we are holding merges for v1.0.0 and this is marked as v1.0.1... But I guess there is not harm shipping this earlier.

@michael-s-molina
Copy link
Member Author

@ktmud We could have some problems with translation. I'm currently working on server side texts and translation generation. The idea here is to hold after 1.0.0 so we can merge all capitalization PRs and execute a throughout test with translation capabilities.

@michael-s-molina
Copy link
Member Author

@ktmud But don't worry about this merged iteration. Currently translations are disabled by default and are incomplete anyway 😄

@junlincc
Copy link
Member

😉 @michael-s-molina the changes you made in those iteration is significant to Superset, we can't wait to see all of them to get in.

amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Jan 14, 2021
Apply capitalization guidelines defined in apache#12343 

Use sentence casing for most places.
villebro pushed a commit that referenced this pull request Jan 25, 2021
Apply capitalization guidelines defined in #12343 

Use sentence casing for most places.
@mistercrunch mistercrunch added 🍒 1.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v1.0.1 🍒 1.0.1 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants