-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: apply capitalization guidelines - iteration 1 (#12343) #12447
chore: apply capitalization guidelines - iteration 1 (#12343) #12447
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12447 +/- ##
==========================================
- Coverage 66.81% 62.44% -4.37%
==========================================
Files 1015 1015
Lines 49544 49530 -14
Branches 5080 5080
==========================================
- Hits 33102 30929 -2173
- Misses 16312 18392 +2080
- Partials 130 209 +79
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for once, i completely understand all the code changes, LGTM!
looks good to me |
Oops, forgot we are holding merges for v1.0.0 and this is marked as v1.0.1... But I guess there is not harm shipping this earlier. |
@ktmud We could have some problems with translation. I'm currently working on server side texts and translation generation. The idea here is to hold after 1.0.0 so we can merge all capitalization PRs and execute a throughout test with translation capabilities. |
@ktmud But don't worry about this merged iteration. Currently translations are disabled by default and are incomplete anyway 😄 |
😉 @michael-s-molina the changes you made in those iteration is significant to Superset, we can't wait to see all of them to get in. |
Apply capitalization guidelines defined in apache#12343 Use sentence casing for most places.
Apply capitalization guidelines defined in #12343 Use sentence casing for most places.
SUMMARY
Apply capitalization guidelines defined in #12343.
@junlincc
TEST PLAN
Check if modified texts are following capitalization guidelines.
ADDITIONAL INFORMATION