Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Design Proposal]Capitalization guidelines for consistency #12343

Closed
mihir174 opened this issue Jan 8, 2021 · 8 comments
Closed

[Design Proposal]Capitalization guidelines for consistency #12343

mihir174 opened this issue Jan 8, 2021 · 8 comments
Labels
guidelines Proposals for new or updated guidelines .pinned Draws attention

Comments

@mihir174
Copy link
Contributor

mihir174 commented Jan 8, 2021

This design proposal aims to make text consistently capitalized across the product, to address issues like #12023

Here are the guidelines @Steejay and I developed, based on design systems from Google, IBM and Atlassian.

Sentence case

Use sentence-case capitalization for everything in the UI (except these **).

Sentence case is predominantly lowercase. Capitalize only the initial character of the first word, and other words that require capitalization, like:

  • Proper nouns. Objects in the product are not considered proper nouns e.g. dashboards, charts, saved queries etc. Proprietary feature names eg. SQL Lab, Preset Manager are considered proper nouns
  • Acronyms (e.g. CSS, HTML)
  • When referring to UI labels that are themselves capitalized from sentence case (e.g. page titles - Dashboards page, Charts page, Saved queries page, etc.)
  • User input that is reflected in the UI. E.g. a user-named a dashboard tab

Sentence case vs. Title case:
Title case: "A Dog Takes a Walk in Paris"
Sentence case: "A dog takes a walk in Paris"

Why sentence case?

  • It’s generally accepted as the quickest to read
  • It’s the easiest form to distinguish between common and proper nouns

How to refer to UI elements

When writing about a UI element, use the same capitalization as used in the UI.

For example, if an input field is labeled “Name” then you refer to this as the “Name input field”. Similarly, if a button has the label “Save” in it, then it is correct to refer to the “Save button”.

Where a product page is titled “Settings”, you refer to this in writing as follows:
“Edit your personal information on the Settings page”.

Often a product page will have the same title as the objects it contains. In this case, refer to the page as it appears in the UI, and the objects as common nouns:

  • Upload a dashboard on the Dashboards page
  • Go to Dashboards
  • View dashboard
  • View all dashboards
  • Upload CSS templates on the CSS templates page
  • Queries that you save will appear on the Saved queries page
  • Create custom queries in SQL Lab then create dashboards

**Exceptions to sentence case:

  • Input labels, buttons and tabs are all caps
@mihir174
Copy link
Contributor Author

mihir174 commented Jan 8, 2021

@junlincc
Copy link
Member

junlincc commented Jan 8, 2021

Awesome! Thank you both. @mihir174 @Steejay Kicking off the implementation following this guideline!

@ktmud
Copy link
Member

ktmud commented Jan 8, 2021

Thanks for the detailed proposal and the reasoning! I believe Superset will greatly benefit from more guidelines like this. Maybe we could even develop our own design system!

Do you think it makes sense to add following exception to the proposal as well?

In general, user inputs should not change cases.

@junlincc
Copy link
Member

junlincc commented Jan 8, 2021

Thanks for the detailed proposal and the reasoning! I believe Superset will greatly benefit from more guidelines like this. Maybe we could even develop our own design system!

Do you think it makes sense to add following exception to the proposal as well?

In general, user inputs should not change cases.

+1. no more forcing upper case in the product..

@mihir174
Copy link
Contributor Author

mihir174 commented Jan 8, 2021

@ktmud yes - totally agree with user inputs appearing exactly as they were inputted

@junlincc junlincc changed the title Design Proposal: Capitalization guidelines for consistency [Design Proposal]Capitalization guidelines for consistency Jan 8, 2021
michael-s-molina added a commit to michael-s-molina/superset that referenced this issue Jan 12, 2021
michael-s-molina added a commit to michael-s-molina/superset that referenced this issue Jan 12, 2021
michael-s-molina added a commit to michael-s-molina/superset that referenced this issue Jan 12, 2021
@michael-s-molina
Copy link
Member

Guidelines added to CONTRIBUTING.md.

villebro pushed a commit that referenced this issue Jan 25, 2021
Apply capitalization guidelines defined in #12343 

Use sentence casing for most places.
ktmud added a commit that referenced this issue Jan 29, 2021
Update capitalization guideline to exempt user inputs from cap transformation.

Based on the discussion here: #12343 (comment)

cc @mihir174
ktmud added a commit that referenced this issue Jan 29, 2021
Update capitalization guideline to exempt user inputs from cap transformation.

Based on the discussion here: #12343 (comment)

cc @mihir174
@rusackas
Copy link
Member

Moved to Design Guidelines page on the Wiki, so I'll call this issue Closed.

@michael-s-molina michael-s-molina added the guidelines Proposals for new or updated guidelines label Sep 29, 2021
DevNoctis1001 added a commit to DevNoctis1001/Superset-data_visualization that referenced this issue Feb 11, 2024
Update capitalization guideline to exempt user inputs from cap transformation.

Based on the discussion here: apache/superset#12343 (comment)

cc @mihir174
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this issue Mar 6, 2024
Update capitalization guideline to exempt user inputs from cap transformation.

Based on the discussion here: apache#12343 (comment)

cc @mihir174
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this issue Mar 6, 2024
Update capitalization guideline to exempt user inputs from cap transformation.

Based on the discussion here: apache#12343 (comment)

cc @mihir174
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
guidelines Proposals for new or updated guidelines .pinned Draws attention
Projects
None yet
Development

No branches or pull requests

5 participants