Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: apply capitalization guidelines - iteration 4 (#12343) #12450

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Apply capitalization guidelines defined in #12343.

@junlincc

TEST PLAN

Check if modified texts are following capitalization guidelines.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Jan 12, 2021

Codecov Report

Merging #12450 (3bb35e0) into master (5504762) will decrease coverage by 1.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12450      +/-   ##
==========================================
- Coverage   64.55%   63.34%   -1.22%     
==========================================
  Files        1018      486     -532     
  Lines       49787    29983   -19804     
  Branches     4971        0    -4971     
==========================================
- Hits        32141    18992   -13149     
+ Misses      17468    10991    -6477     
+ Partials      178        0     -178     
Flag Coverage Δ
cypress ?
javascript ?
python 63.34% <ø> (-0.79%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/db_engine_specs/hive.py 54.61% <0.00%> (-29.24%) ⬇️
superset/databases/commands/create.py 83.67% <0.00%> (-8.17%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/connectors/sqla/models.py 84.31% <0.00%> (-6.28%) ⬇️
superset/db_engine_specs/sqlite.py 90.62% <0.00%> (-6.25%) ⬇️
superset/databases/commands/test_connection.py 84.78% <0.00%> (-4.35%) ⬇️
superset/utils/celery.py 96.42% <0.00%> (-3.58%) ⬇️
superset/models/core.py 85.59% <0.00%> (-3.27%) ⬇️
... and 533 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5504762...3bb35e0. Read the comment docs.

@adam-stasiak
Copy link
Contributor

looks good to me

Copy link
Contributor

@mihir174 mihir174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@michael-s-molina michael-s-molina force-pushed the apply-capitalization-guidelines-4 branch 2 times, most recently from 1937724 to 5db59c5 Compare January 22, 2021 11:30
@rusackas rusackas merged commit fc20e8b into apache:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants