Code

fix: Database connection R6 fixes#15486

Code

Merged

hughhhh merged 175 commits intoapache:masterapache/superset:masterfrom preset-io:lyndsi/r6-polishpreset-io/superset:lyndsi/r6-polishCopy head branch name to clipboardJul 2, 2021

+59-55

Commits

Commits on May 20, 2021

• split db modal file

  eschutho

  committed
  05a1bb7

• split db modal file

  eschutho

  committed
  a8afce9

• hook up available databases

  eschutho

  committed
  b69bf16

Commits on May 21, 2021

• add comment

  eschutho

  committed
  6eae68c

Commits on May 24, 2021

• split db modal file

  eschutho

  committed
  e8cd4f4

• hook up available databases

  eschutho

  committed
  95917e4

Commits on May 25, 2021

• use new validation component

  eschutho

  committed
  e764072

• first draft

  AAfghahi

  committed
  842f856

Commits on May 26, 2021

• use new validation component

  eschutho

  committed
  7cb4098

• first draft

  AAfghahi

  committed
  253053b

• first draft

  AAfghahi

  committed
  a47d52d

• merge

  AAfghahi

  committed
  8cec32b

Commits on May 27, 2021

• Merge branch 'master' of https://github.com/apache/superset into pexdax/db-connection-ui

  hughhhh

  committed
  5a785d7

Commits on May 28, 2021

• using paxdax feature branch

  AAfghahi

  committed
  92d81b9

Commits on Jun 1, 2021

• Creating IconButton

  lyndsiWilliams

  committed
  6d0c45f

• Changed naming: logo is now icon

  lyndsiWilliams

  committed
  b0cdaba

• Hard-coded inset values for ellipses

  lyndsiWilliams

  committed
  8d96434

• Removed default SVG

  lyndsiWilliams

  committed
  3eea36d

• Fixed test

  lyndsiWilliams

  committed
  b0ab2da

• get tests passing

  AAfghahi

  committed
  19a4c3a

• Removed logo from test

  lyndsiWilliams

  committed
  c8b148e

• split db modal file

  

  eschutho

  authored and

  hughhhh

  committed
  e7f0dbb

• hook up available databases

  

  eschutho

  authored and

  hughhhh

  committed
  b57d090

• use new validation component

  

  eschutho

  authored and

  hughhhh

  committed
  271c6e9

• feat(db-connection-ui): Allow users to pick engine (apache#14884)

  Show description for ef63e3c
  hughhhh

  committed
  ef63e3c

• Merge branch 'pexdax/db-connection-ui' into ch6732_editDBModal

  AAfghahi

  authored
  013674b

• Merge branch 'lyndsi/create-icon-button' of https://github.com/preset-io/superset into pexdax/db-connection-ui-show-preferred

  hughhhh

  committed
  8907bc1

• saving for now

  hughhhh

  committed
  96a87d8

• revisions

  AAfghahi

  committed
  9246710

• fix conflicts

  hughhhh

  committed
  0457bfe

• fix package-lock.json

  hughhhh

  committed
  502abec

Commits on Jun 2, 2021

• update styles

  hughhhh

  committed
  717c9ab

• save

  hughhhh

  committed
  e299bfa

• Merge branch 'pexdax/db-connection-ui' of ssh://github.com/apache/superset into ch6732_editDBModal

  AAfghahi

  committed
  25b435b

• # This is a combination of 6 commits.

  Show description for 29a899d
  

  eschutho

  authored and

  hughhhh

  committed
  29a899d

• fix test for db modal

  hughhhh

  committed
  f45cae2

• feat(db-connection-ui): Allow users to pick engine (apache#14884)

  Show description for 1aae834
  hughhhh

  committed
  1aae834

• Merge branch 'master' into pexdax/db-connection-ui

  hughhhh

  authored
  a380629

• pulling feature branch

  AAfghahi

  committed
  c4125fb

• more revisions

  AAfghahi

  committed
  95c7f66

• create 1 function for setting the DB

  hughhhh

  committed
  8cfa0d8

• add function to preferred section

  hughhhh

  committed
  7c610d5

• small refactor and added styling

  hughhhh

  committed
  dcf8144

• used db.backend

  AAfghahi

  committed
  e539834

• add new footer buttons

  hughhhh

  committed
  ef23e53

• add finsh buttong

  hughhhh

  committed
  2602827

• refactor db modal render

  hughhhh

  committed
  530150e

• fix comments issue

  hughhhh

  committed
  508a6b9

• added engine to model

  AAfghahi

  committed
  47c30cb

• elizabeth revisions

  AAfghahi

  committed
  9fac1eb

Commits on Jun 3, 2021

• add header

  hughhhh

  committed
  607e01a

• add bottom footer to sqlalchemy form

  hughhhh

  committed
  b343ca4

• # This is a combination of 6 commits.

  Show description for 145b947
  

  eschutho

  authored and

  hughhhh

  committed
  145b947

• fix test for db modal

  hughhhh

  committed
  cea7b6c

• feat(db-connection-ui): Allow users to pick engine (apache#14884)

  Show description for d5c5167
  hughhhh

  committed
  d5c5167

• elizabeth revisions

  AAfghahi

  committed
  78d7edb

• add back headers

  hughhhh

  committed
  0df0cab

• fix merge conflicts

  hughhhh

  committed
  0d3c31d

• add step

  hughhhh

  committed
  c21987f

• Merge branch 'pexdax/db-connection-ui' into ch6732_editDBModal

  AAfghahi

  committed
  fc6d5d9

• feat: Dynamic Form for edit DB Modal (apache#14845)

  Show description for b8e6687
  

  3 peopleauthored
  b8e6687

Commits on Jun 4, 2021

• address comments

  hughhhh

  committed
  9d2b36e

• fix merge conflicts

  hughhhh

  committed
  6c9fc9c

• oops

  hughhhh

  committed
  4aa2428

• # This is a combination of 6 commits.

  Show description for c0a8c74
  

  eschutho

  authored and

  hughhhh

  committed
  c0a8c74

• fix test for db modal

  hughhhh

  committed
  907165f

• feat(db-connection-ui): Allow users to pick engine (apache#14884)

  Show description for e3a87b9
  hughhhh

  committed
  e3a87b9

• working edit db dynamic modal

  hughhhh

  committed
  2cbe31e

• working preferred branch

  hughhhh

  committed
  514ec63

• remove merge conflicts

  hughhhh

  committed
  5a604e3

• small fix on blocking creating

  hughhhh

  committed
  120866c

Commits on Jun 5, 2021

• feat(db-connection-ui): Big Query Add Database Form (apache#14829)

  Show description for 298f660
  

  7 peopleauthored
  298f660

• feat: adding SSL Toggle to Create Database Modal (apache#14976)

  Show description for 860efef
  

  3 peopleauthored
  860efef

Commits on Jun 7, 2021

• Merge branch 'master' of https://github.com/apache/superset into pexdax/db-connection-ui

  hughhhh

  committed
  07d619e

• Merge branch 'pexdax/db-connection-ui' of https://github.com/apache/superset into pexdax/db-connection-ui

  hughhhh

  committed
  f2b8b04

Commits on Jun 9, 2021

• pull from master

  hughhhh

  committed
  addb946

• feat(database-connection-ui) Allow configuration of Database Images from SupersetText (apache#15023)

  Show description for a9eda01
  hughhhh

  authored
  a9eda01

• fix bug

  hughhhh

  committed
  c2213fc

• additional params to the DatabaseConnectionForm (apache#15071)

  Show description for a95e416
  hughhhh

  authored
  a95e416

Commits on Jun 10, 2021

• feat: Added Steps and centralized Headers (apache#15041)

  AAfghahi

  authored
  cbbb257

• Merge branch 'master' of https://github.com/apache/superset into pexdax/db-connection-ui

  hughhhh

  committed
  5eea4f3

• fix superset_text issue (apache#15095)

  hughhhh

  authored
  c66a853

• fix edit issue by returning parameters properly (apache#15101)

  hughhhh

  authored
  3105020

Commits on Jun 11, 2021

• feat: added alerts (apache#15103)

  Show description for 5cb4871
  AAfghahi

  authored
  5cb4871

• fix: add icons (apache#15122)

  Show description for 91e1045
  AAfghahi

  authored
  91e1045

• Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx

  Show description for 8fe2ec8
  

  hughhhh

  and

  AAfghahi

  authored
  8fe2ec8

• fix: fixing api tests for database connections (apache#15124)

  Show description for 461f64b
  AAfghahi

  authored
  461f64b

Commits on Jun 14, 2021

• fix(db-connection-ui): Additional Query Parameters render (apache#15150)

  Show description for ad706d2
  hughhhh

  authored
  ad706d2

Commits on Jun 15, 2021

• feat(db-connection-ui): Move fields from Extra section and split engine and metadata (apache#15143)

  Show description for 9443344
  hughhhh

  authored
  9443344

• style: Database connect UI Polish - Step 1 (apache#15119)

  Show description for 3c5ce99
  

  lyndsiWilliams

  and

  hughhhh

  authored
  3c5ce99

• fix app from merge

  hughhhh

  committed
  4512228

• fix merge conflicts

  hughhhh

  committed
  bd05f95

• fix tslint issues

  hughhhh

  committed
  3076179

• fix all tslint issue on feature branch

  hughhhh

  committed
  0f38996

• catch errors for dialects with no driver set

  hughhhh

  committed
  e773c8a

• fix dremio issue

  hughhhh

  committed
  2aacd79

• fix dialect issue without driver attr

  hughhhh

  committed
  2052234

Commits on Jun 16, 2021

• Styled step 3 (apache#15187)

  lyndsiWilliams

  authored
  4c74998

• feat: adding server-side validation and unmasked password on create (apache#15151)

  Show description for 7089580
  AAfghahi

  authored
  7089580

• feat: add Close/Finish buttons to DBModal on Edit (apache#15199)

  AAfghahi

  authored
  1a954ff

• fix(db-connection-ui): Allow Dynamic Big Query Edits (apache#15185)

  Show description for f452789
  hughhhh

  authored
  f452789

• fix: Connect on DB Connection wasn't working (apache#15201)

  Show description for a03ad40
  AAfghahi

  authored
  a03ad40

• make available alphabetically sort

  hughhhh

  committed
  9efb2d2

• make available alphabetically sort II

  hughhhh

  committed
  dee8b24

• fix selection

  hughhhh

  committed
  4bfc64b

• remove console.log

  hughhhh

  committed
  f1ff72f

• fix styling

  hughhhh

  committed
  7b4ae58

• fix: fix api_test and typeScript error (apache#15202)

  AAfghahi

  authored
  52f9658

• fix big query issue

  hughhhh

  committed
  301eb51

• Merge branch 'pexdax/db-connection-ui' of https://github.com/apache/superset into pexdax/db-connection-ui

  hughhhh

  committed
  cbbcf1b

Commits on Jun 17, 2021

• allow for query params

  hughhhh

  committed
  c32a387

• feat: Added Dynamic form link to SQL Alchemy Form (apache#15208)

  Show description for 9cecb8b
  AAfghahi

  authored
  9cecb8b

• Merge branch 'master' into pexdax/db-connection-ui

  hughhhh

  authored
  0b306a4

• fix: fix api tests for test_available (apache#15210)

  Show description for f8acc5f
  AAfghahi

  authored
  f8acc5f

• feat: added Spinner to DB Modal (apache#15229)

  Show description for 0a517a0
  AAfghahi

  authored
  0a517a0

• Made header sticky (apache#15204)

  lyndsiWilliams

  authored
  ad3bbfb

• fix: make Edit DB modal look similar to create Modal (apache#15231)

  Show description for 7505601
  AAfghahi

  authored
  7505601

• fix: DB Connection UI R2 Fixes (apache#15232)

  Show description for 7270d26
  hughhhh

  authored
  7270d26

• small fixes on bigquery edit

  hughhhh

  committed
  b557935

• only wrap encrypted with bigquery

  hughhhh

  committed
  65b0241

• specific conditions for wrapping big query items

  hughhhh

  committed
  8ff4f7b

• dix additional params

  hughhhh

  committed
  1570642

• Merge branch 'master' of https://github.com/apache/superset into pexdax/db-connection-ui

  hughhhh

  committed
  243af7f

• fix allow display name in sqlalchemy form

  hughhhh

  committed
  7ff8777

• backend before engine

  hughhhh

  committed
  4dfa544

• fix: do not use Marshmallow validation in partial params validation (apache#15236)

  Show description for c1a0fc9
  betodealmeida

  authored
  c1a0fc9

• make display name required

  hughhhh

  committed
  27efb29

Commits on Jun 18, 2021

• reset validation errors onClose (apache#15243)

  hughhhh

  authored
  9d9b681

• fix: Edit for all dynamic forms (apache#15244)

  Show description for b9ffd41
  hughhhh

  authored
  b9ffd41

Commits on Jun 19, 2021

• wrap configuration method (apache#15274)

  hughhhh

  authored
  1f45607

Commits on Jun 22, 2021

• add more specific engine elastic search (apache#15287)

  hughhhh

  authored
  19dd302

• do a deep copy of obj before POST (apache#15298)

  hughhhh

  authored
  d9d863b

• feat: add Back button to extra options (apache#15300)

  Show description for e7f71f3
  AAfghahi

  authored
  e7f71f3

• chore: Add tooltips and button to Connect Postgresql DB Modal Form (apache#15179)

  Show description for b6138cf
  

  andrewbastian

  and

  andrewbastian

  authored
  b6138cf

• style: Database Modal UI Polish (apache#15234)

  Show description for a64f1e7
  lyndsiWilliams

  authored
  a64f1e7

• feat: allow editing (apache#15308)

  Show description for 7c42a7c
  AAfghahi

  authored
  7c42a7c

• feat: Added error alert for DB connection Modal (apache#15242)

  Show description for 5de931a
  AAfghahi

  authored
  5de931a

• fix: validation on edit (apache#15310)

  hughhhh

  authored
  725f406

Commits on Jun 23, 2021

• fix: Big Query Error messaging (apache#15334)

  Show description for c64ad88
  hughhhh

  authored
  c64ad88

• update styles

  hughhhh

  committed
  c283be6

• feat: big Query using back button (apache#15338)

  AAfghahi

  authored
  bc727f4

Commits on Jun 24, 2021

• fix: password errors on validation (apache#15372)

  Show description for 913b29c
  hughhhh

  authored
  913b29c

Commits on Jun 25, 2021

• feat: updated Error Alert (apache#15377)

  AAfghahi

  authored
  56480ea

• Updated styling (apache#15379)

  lyndsiWilliams

  authored
  df46a25

• fix password error filter

  hughhhh

  committed
  d9b743d

• feat: Arash/password field error (apache#15388)

  AAfghahi

  authored
  7b5e468

• fix: Back Button on Create for DB conncetion (apache#15389)

  Show description for 08318fc
  AAfghahi

  authored
  08318fc

• fix doc (apache#15393)

  hughhhh

  authored
  4db07e2

Commits on Jun 28, 2021

• style: Database Connection Modal UI Polish R5 (apache#15412)

  Show description for dd47bde
  lyndsiWilliams

  authored
  dd47bde

• make alerts configurable (apache#15404)

  hughhhh

  authored
  ef0b393

• fix: Allow users to override database connection docs (apache#15434)

  Show description for 4b46a17
  hughhhh

  authored
  4b46a17

Commits on Jun 29, 2021

• fix: Error Icon not showing up on errored input fieds on validation (apache#15431)

  Show description for 74ce6e6
  andrewbastian

  authored
  74ce6e6

• test: RTL testing on DatabaseModal (apache#15394)

  Show description for c3193a8
  lyndsiWilliams

  authored
  c3193a8

• test: Add e2e testing (apache#15376)

  Show description for bb396a7
  hughhhh

  authored
  bb396a7

• fix merge conflicts

  hughhhh

  committed
  5873784

• Fixed "connetion" typo (apache#15458)

  lyndsiWilliams

  authored
  2db0f25

• fix: Database connection modal touch up (apache#15463)

  Show description for 3eb6db8
  lyndsiWilliams

  authored
  3eb6db8

• Update modal.test.ts

  hughhhh

  authored
  26a411d

• fix: Showing errors for SQLA forms (apache#15462)

  Show description for 47644d5
  hughhhh

  authored
  47644d5

• Merge branch 'master' of https://github.com/apache/superset into pexdax/db-connection-ui

  hughhhh

  committed
  44504f5

• Merge branch 'pexdax/db-connection-ui' of https://github.com/apache/superset into pexdax/db-connection-ui

  hughhhh

  committed
  1ce8104

• fix: Update Invalid Port SIP-40 Reference (apache#15464)

  hughhhh

  authored
  5bfbfff

Commits on Jun 30, 2021

• Merge branch 'master' into pexdax/db-connection-ui

  hughhhh

  authored
  4cae8cd

• Fixed jumpy header text

  lyndsiWilliams

  committed
  90abcf6

• fix: Edit Modal not saving properly (apache#15468)

  AAfghahi

  authored
  f8da689

• Aligned info icons on dynamic form

  lyndsiWilliams

  committed
  364085e

• fix: merge conflict (apache#15479)

  Show description for ea48784
  betodealmeida

  authored
  ea48784

• Fixed line-height in header, also fixed translation functions in BigQuery

  lyndsiWilliams

  committed
  ef94ccf

• Updated placeholder text in additional params field

  lyndsiWilliams

  committed
  4936237

• Fixed padding in edit form

  lyndsiWilliams

  committed
  6f9d23b

• Merge branch 'master' into pexdax/db-connection-ui

  hughhhh

  authored
  5639c51

• Merge branch 'pexdax/db-connection-ui' of https://github.com/apache/superset into lyndsi/r6-polish

  lyndsiWilliams

  committed
  5970422

• Corrected placeholder text in BigQuery > Service Account field

  lyndsiWilliams

  committed
  ef94b38

Commits on Jul 1, 2021

• Make linter happy

  lyndsiWilliams

  committed
  837c3f2

Commits on Jul 2, 2021

• Merge branch 'master' of https://github.com/apache/superset into lyndsi/r6-polish

  lyndsiWilliams

  committed
  461b655