Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sqllab): Floating numbers not sorting correctly in result column #17573

Merged
merged 7 commits into from
Dec 4, 2021
Merged

fix(sqllab): Floating numbers not sorting correctly in result column #17573

merged 7 commits into from
Dec 4, 2021

Commits on Nov 29, 2021

  1. Floating nums now sorting correctly with parseFloatingNums function

    @lyndsiWilliams
    lyndsiWilliams committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    a57cf70 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2021

  1. Floating numbers AND strings now sorting correctly, +locale comparison

    @lyndsiWilliams
    lyndsiWilliams committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    43742de View commit details
    Browse the repository at this point in the history

  2. Added NULL handling back to sort function

    @lyndsiWilliams
    lyndsiWilliams committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    580f9d9 View commit details
    Browse the repository at this point in the history

  3. Moved parseFloatingNums outside of sortResults

    @lyndsiWilliams
    lyndsiWilliams committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    628a549 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2021

  1. Removed localeCompare and added testing

    @lyndsiWilliams
    lyndsiWilliams committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    8be6346 View commit details
    Browse the repository at this point in the history

  2. Add equality check back to sort function

    @lyndsiWilliams
    lyndsiWilliams committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    4904ef1 View commit details
    Browse the repository at this point in the history

  3. Added floatValue nit

    @lyndsiWilliams
    lyndsiWilliams committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    d1d0751 View commit details
    Browse the repository at this point in the history