-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: miss-spelling on CONTRIBUTING.md line 1351 #17760
Conversation
Thanks for the contribution @MayUWish ! It appears you've mistakenly removed the |
hey Meitong! I think you may have not run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Meitong! +1 on the package.json
, I believe you'll need to run npm ci
in superset-frontend
to fix this. Reach out on Slack or in office hours today if you'd like some help.
Could you also fill out the "Summary" portion of the description of your PR?
* fix miss-spelling on CONTRIBUTING.md line 1351 * added superset-frontend/package-lock.json
* fix miss-spelling on CONTRIBUTING.md line 1351 * added superset-frontend/package-lock.json
SUMMARY
Correct miss-spelling
<datasouce_id>__<datasource_type>
to<datasource_id>__<datasource_type>
on CONTRIBUTING.md line 1351BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION