Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ExploreCtasResultsButton): convert to functional component #17939

Conversation

ChristopherCFleming
Copy link
Contributor

SUMMARY

Updated from class component into functional component. Moved onClick below Visualize.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2022-01-05 at 2 34 13 PM

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@ChristopherCFleming ChristopherCFleming changed the title Feat(ExploreCtasResultsButton): Convert to Functional Component refactor(ExploreCtasResultsButton): convert to functional component Jan 5, 2022
@AAfghahi
Copy link
Member

AAfghahi commented Jan 5, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2022

@AAfghahi Ephemeral environment spinning up at http://34.219.47.255:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@eschutho eschutho added the Superset-Community-Partners Preset community partner program participants label Jan 5, 2022
@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #17939 (93d1ec2) into master (5da3c45) will increase coverage by 0.21%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17939      +/-   ##
==========================================
+ Coverage   66.34%   66.56%   +0.21%     
==========================================
  Files        1569     1573       +4     
  Lines       61687    61799     +112     
  Branches     6241     6294      +53     
==========================================
+ Hits        40927    41134     +207     
+ Misses      19162    19013     -149     
- Partials     1598     1652      +54     
Flag Coverage Δ
javascript 51.39% <22.22%> (+0.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/SqlLab/components/ResultSet/index.tsx 50.73% <ø> (ø)
...lLab/components/ExploreCtasResultsButton/index.jsx 30.76% <22.22%> (+19.00%) ⬆️
...ugins/plugin-chart-echarts/src/Timeseries/index.ts 25.00% <0.00%> (-25.00%) ⬇️
.../plugin-chart-echarts/src/Timeseries/Step/index.ts 25.00% <0.00%> (-25.00%) ⬇️
.../plugin-chart-echarts/src/Timeseries/Area/index.ts 33.33% <0.00%> (-16.67%) ⬇️
...-chart-echarts/src/Timeseries/Regular/Bar/index.ts 33.33% <0.00%> (-16.67%) ⬇️
...chart-echarts/src/Timeseries/Regular/Line/index.ts 33.33% <0.00%> (-16.67%) ⬇️
...rt-echarts/src/Timeseries/Regular/Scatter/index.ts 33.33% <0.00%> (-16.67%) ⬇️
...echarts/src/Timeseries/Regular/SmoothLine/index.ts 33.33% <0.00%> (-16.67%) ⬇️
...rontend/src/explore/components/EmbedCodeButton.jsx 66.66% <0.00%> (-12.29%) ⬇️
... and 93 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5da3c45...93d1ec2. Read the comment docs.

@ChristopherCFleming ChristopherCFleming force-pushed the chrisFleming/ExploreCtasResultsButton-to-functional branch from 6117cdb to d78d0dc Compare January 14, 2022 21:58
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 14, 2022
@eschutho
Copy link
Member

/testenv up

@eschutho
Copy link
Member

@AAfghahi we can't test ctas on the ephemeral, can we?

@github-actions
Copy link
Contributor

@eschutho Ephemeral environment spinning up at http://35.87.218.85:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@AAfghahi
Copy link
Member

@AAfghahi we can't test ctas on the ephemeral, can we?

I don't think we can, but we also couldn't enable it with a SQLite example db. I can pull it down and test in postgres.

Copy link
Member

@lyndsiWilliams lyndsiWilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this, thank you!

Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking great @ChristopherCFleming! Just a few small nits.

@eschutho
Copy link
Member

eschutho commented Feb 8, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2022

@eschutho Ephemeral environment spinning up at http://34.215.151.120:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@AAfghahi
Copy link
Member

AAfghahi commented Feb 8, 2022

tested this locally to see that it works:

Screen.Recording.2022-02-08.at.2.27.11.PM.mov

Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you @ChristopherCFleming!

@eschutho eschutho merged commit 51f716f into apache:master Feb 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2022

Ephemeral environment shutdown and build artifacts deleted.

@ChristopherCFleming
Copy link
Contributor Author

Thank you! Appreciate your time and guidance.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L Superset-Community-Partners Preset community partner program participants 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants