Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed dancing tooltip in database list action buttons #18686

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

lyndsiWilliams
Copy link
Member

SUMMARY

I stopped the dancing tooltip in the database list's action buttons by setting its button's display to inline-block and height to 100%.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:

dbDancingTooltip

AFTER:

dbTooltipInTheCorner

TESTING INSTRUCTIONS

  • In the database list, hover over the action buttons
  • Observe that the tooltip does not dance

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@superset-github-bot superset-github-bot bot added the Superset-Community-Partners Preset community partner program participants label Feb 11, 2022
@lyndsiWilliams lyndsiWilliams removed the Superset-Community-Partners Preset community partner program participants label Feb 11, 2022
@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #18686 (b4739a7) into master (a7d505d) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18686   +/-   ##
=======================================
  Coverage   66.25%   66.25%           
=======================================
  Files        1604     1604           
  Lines       62807    62806    -1     
  Branches     6333     6333           
=======================================
  Hits        41613    41613           
+ Misses      19542    19541    -1     
  Partials     1652     1652           
Flag Coverage Δ
javascript 51.21% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tend/src/views/CRUD/data/database/DatabaseList.tsx 65.47% <ø> (ø)
...rontend/src/visualizations/TimeTable/TimeTable.jsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7d505d...b4739a7. Read the comment docs.

@hughhhh hughhhh merged commit 801091b into apache:master Feb 14, 2022
@lyndsiWilliams lyndsiWilliams deleted the lyndsi/fix-another-dancing-tooltip branch February 14, 2022 21:06
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants