-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: SQL Lab autocomplete for selected tables #19047
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19047 +/- ##
==========================================
- Coverage 66.52% 66.40% -0.13%
==========================================
Files 1641 1645 +4
Lines 63476 63784 +308
Branches 6444 6537 +93
==========================================
+ Hits 42227 42355 +128
- Misses 19585 19748 +163
- Partials 1664 1681 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
f96865b
to
32f43e1
Compare
/testenv up |
@pkdotson Ephemeral environment spinning up at http://34.217.100.234:8080. Credentials are |
/testenv up |
@hughhhh Ephemeral environment spinning up at http://54.202.235.184:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA tested passed. Verified autocomplete worked for table name when user have selected table in left panel
Ephemeral environment shutdown and build artifacts deleted. |
(cherry picked from commit a21d8a0)
SUMMARY
Updated logic to fix the autocomplete render in sqllab for selected tables in the left panel
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2022-03-04.at.1.16.48.PM.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION