Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Databricks native driver #20320

Merged

Conversation

betodealmeida
Copy link
Member

SUMMARY

Databricks now has their own DB API 2 library, so I switched the recommendation to use it. Also added a DB engine spec for it.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

N/A

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #20320 (2fa30f1) into master (07b4a71) will decrease coverage by 0.20%.
The diff coverage is 100.00%.

❗ Current head 2fa30f1 differs from pull request most recent head 152ffa9. Consider uploading reports for the commit 152ffa9 to get more accurate results

@@            Coverage Diff             @@
##           master   #20320      +/-   ##
==========================================
- Coverage   66.64%   66.44%   -0.21%     
==========================================
  Files        1738     1734       -4     
  Lines       65053    65007      -46     
  Branches     6884     6872      -12     
==========================================
- Hits        43356    43193     -163     
- Misses      19950    20057     +107     
- Partials     1747     1757      +10     
Flag Coverage Δ
hive ?
mysql 82.29% <100.00%> (+<0.01%) ⬆️
postgres 82.36% <100.00%> (+<0.01%) ⬆️
presto ?
python 82.44% <100.00%> (-0.35%) ⬇️
sqlite 82.09% <100.00%> (+<0.01%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/databricks.py 92.30% <100.00%> (+1.39%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
...-ui-chart-controls/src/utils/defineSavedMetrics.ts 66.66% <0.00%> (-33.34%) ⬇️
...mponents/DataTablesPane/components/SamplesPane.tsx 69.76% <0.00%> (-27.91%) ⬇️
...erset-ui-chart-controls/src/utils/columnChoices.ts 80.00% <0.00%> (-20.00%) ⬇️
superset/db_engine_specs/hive.py 70.22% <0.00%> (-15.65%) ⬇️
superset/db_engine_specs/presto.py 83.36% <0.00%> (-5.34%) ⬇️
superset/connectors/sqla/models.py 89.05% <0.00%> (-1.19%) ⬇️
.../src/explore/components/DataTableControl/index.tsx 64.04% <0.00%> (-0.73%) ⬇️
...erset-frontend/src/components/Chart/chartAction.js 55.26% <0.00%> (-0.66%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07b4a71...152ffa9. Read the comment docs.

@betodealmeida betodealmeida merged commit ec331e6 into apache:master Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants