-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add dataset visuals for when a table is selected #21893
Conversation
{tableName} | ||
<RefreshLabel | ||
onClick={() => { | ||
console.log( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this console log necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not, it was more a flag/placeholder for when the functionality is added into the next ticket.
@@ -65,6 +65,9 @@ export function datasetReducer( | |||
} | |||
} | |||
|
|||
const prevUrl = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is still temporary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure the status of this URL, I just moved it out so it didn't get lost in the middle of the other components.
Codecov Report
@@ Coverage Diff @@
## master #21893 +/- ##
===========================================
+ Coverage 55.55% 66.91% +11.36%
===========================================
Files 1806 1807 +1
Lines 69140 69359 +219
Branches 7393 7474 +81
===========================================
+ Hits 38409 46415 +8006
+ Misses 28822 21014 -7808
- Partials 1909 1930 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
import { EmptyStateBig } from 'src/components/EmptyState'; | ||
|
||
type DatasetPanelProps = { | ||
tableName?: string | null | undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the null | undefined
taking into account that the field is optional? Cannot just be :
tableName?: string
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah good call! Corrected in this commit
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, this prop is null
when a table isn't selected so I added it to the type in this commit
. Undefined wasn't needed here though, so still a good call, thanks! 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
heheh ok ok 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
SUMMARY
This PR implements the visuals in the dataset panel that appear when a table is selected.
ANIMATED GIF
TESTING INSTRUCTIONS
http://localhost:9000/dataset/add/?testing
ADDITIONAL INFORMATION