Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure that gsheets db connection form loads properly #22361

Merged
merged 1 commit into from
Dec 10, 2022

Conversation

eschutho
Copy link
Member

@eschutho eschutho commented Dec 7, 2022

SUMMARY

In #21573 we added a hook to load the driver for the database selected, but it was causing some runtime errors for gsheets, so I moved it to the base db connection modal component.

TESTING INSTRUCTIONS

Opening a db connection modal edit screen for gsheets should work. Also, as a side effect, creating saving and editing databases should still work properly and should be passing a driver param to the api.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #22361 (a839a84) into master (8afe724) will increase coverage by 0.01%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master   #22361      +/-   ##
==========================================
+ Coverage   66.85%   66.87%   +0.01%     
==========================================
  Files        1847     1847              
  Lines       70561    70553       -8     
  Branches     7737     7736       -1     
==========================================
+ Hits        47174    47179       +5     
+ Misses      21380    21373       -7     
+ Partials     2007     2001       -6     
Flag Coverage Δ
javascript 53.83% <88.88%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ase/DatabaseModal/DatabaseConnectionForm/index.tsx 90.90% <87.50%> (-1.40%) ⬇️
...c/views/CRUD/data/database/DatabaseModal/index.tsx 40.99% <100.00%> (-0.09%) ⬇️
...ilters/FilterBar/FilterControls/FilterControls.tsx 67.30% <0.00%> (-1.32%) ⬇️
...ols/FilterControl/AdhocFilterEditPopover/index.jsx 70.21% <0.00%> (-0.63%) ⬇️
...omponents/nativeFilters/FilterBar/Header/index.tsx 95.00% <0.00%> (-0.24%) ⬇️
...rontend/src/components/DropdownContainer/index.tsx 72.83% <0.00%> (ø)
...rontend/src/views/CRUD/dashboard/DashboardList.tsx 56.60% <0.00%> (ø)
.../components/nativeFilters/FilterBar/Horizontal.tsx 100.00% <0.00%> (ø)
...ts/nativeFilters/FilterBar/ActionButtons/index.tsx 78.57% <0.00%> (ø)
...ols/DndColumnSelectControl/ColumnSelectPopover.tsx 3.37% <0.00%> (ø)
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eschutho
Copy link
Member Author

eschutho commented Dec 8, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

@eschutho Ephemeral environment spinning up at http://54.202.209.100:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@lyndsiWilliams lyndsiWilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, I also tested this locally and everything works as described.

@eschutho eschutho merged commit 368e7e6 into apache:master Dec 10, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

jinghua-qa pushed a commit to preset-io/superset that referenced this pull request Dec 12, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.49 size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants