Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Move RLS to src/pages folder #22775

Closed
wants to merge 1 commit into from
Closed

chore: Move RLS to src/pages folder #22775

wants to merge 1 commit into from

Conversation

EugeneTorap
Copy link
Contributor

SUMMARY

Moved RowLevelSecurityList to src/pages folder to apply the direction outlined in #22330

This work is part of SIP-61

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@EugeneTorap EugeneTorap mentioned this pull request Jan 18, 2023
Merged
9 tasks
@EugeneTorap
Copy link
Contributor Author

@michael-s-molina @lyndsiWilliams Can you review it?

@michael-s-molina
Copy link
Member

@EugeneTorap The only files that should go into src/pages are index.tsx and RowLevelSecurityList.test.tsx

@EugeneTorap EugeneTorap deleted the chore/move-rls-to-src-pages branch January 23, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayurnewase mayurnewase Awaiting requested review from mayurnewase

@michael-s-molina michael-s-molina Awaiting requested review from michael-s-molina

@john-bodley john-bodley Awaiting requested review from john-bodley

@dpgaspar dpgaspar Awaiting requested review from dpgaspar

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EugeneTorap @michael-s-molina