feat: drill by modal

[lilykuang]

SUMMARY

• Create a Modal component that takes chart's formData
• Modal title: Drill by: {origin chart's name}
• In the footer, "Close" primary button and "Edit chart" secondary button that does nothing for now

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[kgabryje]

Could we remove the separator line from the footer to much the design?

[estebanbouza]

@lilykuang I'm running this code from the docker-compose.yml file in it. I can't see the drill popup when navigating to the same USA Births Names dashboard. It's a clean install (no prior docker images exist in the system, no pre-existing volumes used)
What am I missing to be able to preview this feature?

[lilykuang]

@lilykuang I'm running this code from the docker-compose.yml file in it. I can't see the drill popup when navigating to the same USA Births Names dashboard. It's a clean install (no prior docker images exist in the system, no pre-existing volumes used) What am I missing to be able to preview this feature?

@estebanbouza There is a feature flag DRILL_BY need to set to True in superset/config.py
https://github.com/apache/superset/blob/master/superset/config.py#L481

[kgabryje]

Lgtm

[codecov]

Codecov Report

Merging #23458 (99b9141) into master (9fbfd1c) will decrease coverage by 0.03%.
The diff coverage is 76.00%.

❗ Current head 99b9141 differs from pull request most recent head 7410e02. Consider uploading reports for the commit 7410e02 to get more accurate results

@@            Coverage Diff             @@
##           master   #23458      +/-   ##
==========================================
- Coverage   67.59%   67.57%   -0.03%     
==========================================
  Files        1910     1914       +4     
  Lines       73712    73857     +145     
  Branches     7973     8023      +50     
==========================================
+ Hits        49829    49912      +83     
- Misses      21842    21901      +59     
- Partials     2041     2044       +3     

Flag	Coverage Δ
javascript	53.89% <76.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...c/filters/components/Select/SelectFilterPlugin.tsx	64.63% <ø> (-0.85%)	⬇️
.../src/components/Chart/DrillBy/DrillByMenuItems.tsx	89.47% <64.28%> (ø)
...tend/src/components/Chart/DrillBy/DrillByModal.tsx	90.90% <90.90%> (ø)

... and 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more