chore: refactor file upload commands #28164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eschutho
reviewed
Apr 22, 2024
| "description": "If duplicate columns are not overridden," | ||
| "they will be presented as 'X.1, X.2 ...X.x'." | ||
| } | ||
| ) |
eschutho
approved these changes
Apr 22, 2024
qleroy
pushed a commit
to qleroy/superset
that referenced
this pull request
Apr 28, 2024
9 tasks
jzhao62
pushed a commit
to jzhao62/superset
that referenced
this pull request
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Small refactor on
CSVImportCommandandExcelImportCommandto DRY and make it more easily extendable and maintainable.Using dependency injection on a generic
UploadCommandofBaseReadersthat will be able to read a certain type of file.Pandas lib is able to read from multiple file types, CSV, HTML, Excel, XML, Latex, Feather, SAS XPORT etc. So with this refactor it will be much simpler and clean to add support for new file types.
Also this PR fixes the following bugs on reader options:
overrite_duplicates: was an existing option that wasn't actually implemented, removed since I found no option for it on pandasread_csvdecimal: was not actually implementedBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION