[TINKERPOP-2927] Relax steps extensibility strictness #2027
Conversation
In this commit the next changes are done for the Step classes: - Make private fields as protected - Allow to overwride any method by removing `final` keyword - Allow to extend any Step class by removing `final` keyword - Add getter methods for some fields which might be useful for Step information retrieval https://issues.apache.org/jira/browse/TINKERPOP-2927 Signed-off-by: Oleksandr Porunov <alexandr.porunov@gmail.com>
|
Thanks @porunov for submitting this PR. The changes all look valid to me, but opening all of this up is a big change to TinkerPop and needs further consideration. Could you make a [DISCUSS] thread on the dev maillist to ensure that the community is aligned behind this change? |
Thank you for the feedback. I opened the discussion thread here: https://lists.apache.org/thread/vjbjh29kwjhd5lcmkqqqqrhw7rw2ynh9 |
Codecov Report
@@ Coverage Diff @@
## 3.6-dev #2027 +/- ##
=============================================
- Coverage 69.39% 64.51% -4.89%
=============================================
Files 878 25 -853
Lines 42103 3793 -38310
Branches 5643 0 -5643
=============================================
- Hits 29219 2447 -26772
+ Misses 10891 1179 -9712
+ Partials 1993 167 -1826 see 853 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Marked this PR as draft for now until we have some consensus in the discussion thread. |
|
Going to close this PR based on the discussion on the dev list. Additional steps can be opened up in the future but will be handled on a case by case basis. See dev list discussion for more details. |
In this commit the next changes are done for the Step classes:
finalkeywordfinalkeywordIssue: https://issues.apache.org/jira/browse/TINKERPOP-2927
Discussion: https://lists.apache.org/thread/vjbjh29kwjhd5lcmkqqqqrhw7rw2ynh9