Make CoalesceStep extensible #2031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related issue: https://issues.apache.org/jira/browse/TINKERPOP-2927 Signed-off-by: Oleksandr Porunov <alexandr.porunov@gmail.com>
|
The failed test is most likely flaky: |
|
I'm guessing you just want to override the flatMap() method? FlatMapStep seems to be fairly stable. VOTE +1 |
|
VOTE+1 |
porunov
added a commit
to porunov/tinkerpop
that referenced
this pull request
Apr 20, 2023
Signed-off-by: Oleksandr Porunov <alexandr.porunov@gmail.com>
Yes, that's right. The idea is to change |
|
VOTE +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements part of #2027 . Close this PR without merging in case #2027 is merged.
This PR will make possible to extend
CoalesceStepwhich is needed for JanusGraph/janusgraph#2996 . This will help creating a replacement step for original CoalesceStep with optimizations in place.Related issue: https://issues.apache.org/jira/browse/TINKERPOP-2927