TPv2 Update Angular and make compilation stricter (#6391)

* Fix broken jasmine-core peer dependency

* update Angular to 12

* Update Angular to version 13

* alphabetize compiler options, stop emitting decorator metadata

* Update lib to ES2020, now targeting ES2017

* Update gitignore for new Angular cache location

* Update engine restriction, stop using deprecated ng build option

* More strict compilation, including for templates

* Fix compilation errors

* Squash warning about known commonJS dependency

* Fix tests

* Fix end-to-end tests

* make end-to-end tests compile more strict

* Update package-lock because somehow that didn't happen

* Update node typings to match required Node version

experimental/traffic-portal/.gitignore

@@ -12,8 +12,7 @@
 
 # compiled output
 /dist
-/tmp
-/out-tsc
+/.angular
 # Only exists if Bazel was run
 /bazel-out
 

experimental/traffic-portal/angular.json

@@ -20,6 +20,9 @@
 				"build": {
 					"builder": "@angular-devkit/build-angular:browser",
 					"options": {
+						"allowedCommonJsDependencies": [
+							"chart.js"
+						],
 						"outputPath": "dist/traffic-portal/browser",
 						"index": "src/index.html",
 						"main": "src/main.ts",

experimental/traffic-portal/e2e/src/app.e2e-spec.ts

@@ -25,16 +25,20 @@ describe("workspace-project App", () => {
 	});
 
 	it("should allow login", async done => {
-		await page.usernameInput.sendKeys("admin");
-		await page.passwordInput.sendKeys("twelve12");
+		// TODO: put this in a config somewhere
+		await Promise.all([
+			page.usernameInput.sendKeys("admin"),
+			page.passwordInput.sendKeys("twelve12")
+		]);
 		await page.loginButton.click();
+		const loggedInURL = `${browser.baseUrl}core`;
 		try {
-			await browser.wait(until.urlIs(browser.baseUrl), 1000);
+			await browser.wait(until.urlIs(loggedInURL), 1000);
 		} catch(e) {
 			done.fail(`page did not navigate after login: ${e}`);
 			return;
 		}
-		expect(browser.getCurrentUrl()).toBe(browser.baseUrl);
+		expect(browser.getCurrentUrl()).toBe(loggedInURL);
 		done();
 	});
 

experimental/traffic-portal/e2e/tsconfig.json

@@ -1,8 +1,14 @@
 {
 	"extends": "../tsconfig.json",
 	"compilerOptions": {
-		"outDir": "../out-tsc/e2e",
+		"allowUnreachableCode": false,
+		"allowUnusedLabels": false,
 		"module": "commonjs",
+		"noImplicitReturns": true,
+		"noImplicitOverride": true,
+		"noUnusedLocals": true,
+		"noUnusedParameters": true,
+		"outDir": "../out-tsc/e2e",
 		"strict": true,
 		"target": "es2018",
 		"types": [