[TVMScript] Printer entry point #12462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yelite
changed the title
23 tasks
yelite
force-pushed
the
tunip-entry-point
branch
from
6692151
to
2cab720
Compare
yelite
force-pushed
the
tunip-entry-point
branch
from
2cab720
to
37e125e
Compare
junrushao
reviewed
Aug 19, 2022
junrushao
reviewed
Aug 19, 2022
| #include <tvm/node/object_path.h> | ||
|
|
||
| namespace tvm { | ||
| namespace script { |
There was a problem hiding this comment.
Just curious, what do you think works better, tvm::script::printer or tvm::script
There was a problem hiding this comment.
If the function name is Script, I think tvm::script::printer is a better choice. Otherwise the purpose of this function is less clear, because it's a free function rather than a method on IR node.
There was a problem hiding this comment.
I moved it to the tvm::script::printer
|
Otherwise the PR looks nice to me! |
junrushao
approved these changes
Aug 21, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
This PR: - Adds an entry point for the TVMScript Unified Printer - Adds a helper object class `RootNodeContainer` to provide an injection point for the actual printer implementation to add specialized logic on the root node to print. Tracking issue: apache#11912
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
RootNodeContainerto provide an injection point for the actual printer implementation to add specialized logic on the root node to print.This PR is in draft state because it's branched off from a pending PR #12396
Tracking issue: #11912
cc @junrushao1994 @gbonik