Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TVMScript] TIR Printer: Var and Type #12492

Closed
wants to merge 1 commit into from
Closed

[TVMScript] TIR Printer: Var and Type #12492

wants to merge 1 commit into from

Conversation

yelite
Copy link
Contributor

@yelite yelite commented Aug 18, 2022 •
edited
Loading

This PR:

  • Adds printing function for Var and Type in TIR
  • Update the traced_object_functor to require type parameter on set_dispatch for better code readability.
  • Add the TracedObject variants of helper method and constructors in Doc.

This PR is in draft state because it's branched off from a pending PR #12462

Tracking issue: #11912

cc @junrushao @gbonik

@yelite yelite mentioned this pull request Aug 18, 2022
Closed
23 tasks
@yelite yelite mentioned this pull request Aug 19, 2022
Closed
@yelite yelite force-pushed the tunip-tir-var branch 2 times, most recently from a74e05a to 10586ca Compare August 21, 2022 04:10
@yelite yelite marked this pull request as ready for review August 21, 2022 04:11
@Hzfengsy
Copy link
Member

cc @junrushao Can you help to review?

@junrushao junrushao self-assigned this Sep 12, 2022
@junrushao
Copy link
Member

Let's split this PR into 2:

  • The infrastructure change
  • Printer to Var and Type

@yelite yelite mentioned this pull request Sep 17, 2022
Merged
@yelite
Copy link
Contributor Author

yelite commented Sep 17, 2022

Let's split this PR into 2:

  • The infrastructure change
  • Printer to Var and Type

The infra change is split into #12829

junrushao pushed a commit that referenced this pull request Sep 17, 2022
@yelite @gbonik
[TVMScript] Add more helper functions to the printer infra (#12829)
1ecf084 
This PR is split from #12492, to make the necessary updates to the printer infra for future PRs of TIR printer.

Tracking issue: #11912

Co-authored-by: Greg Bonik <gbonik@octoml.ai>
@yelite @gbonik
Add TIR var and type printing
0e0e4a3 
Co-authored-by: Greg Bonik <gbonik@octoml.ai>
@areusch areusch added needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it and removed needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it labels Oct 19, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
@yelite @gbonik @xinetzone
[TVMScript] Add more helper functions to the printer infra (apache#12829
f9de7aa 
)

This PR is split from apache#12492, to make the necessary updates to the printer infra for future PRs of TIR printer.

Tracking issue: apache#11912

Co-authored-by: Greg Bonik <gbonik@octoml.ai>
@junrushao junrushao closed this Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junrushao junrushao Awaiting requested review from junrushao

Assignees

@junrushao junrushao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yelite @Hzfengsy @junrushao @areusch