refactor: convert puppeteer to TS #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failing because it still has the old TS version it seems... anything I can do to fix that? 😓 EDIT: for now, manually reverted the change to something that's still compatible; I've added a TODO for later 👍 |
vladfrangu
force-pushed
the
ts/puppeteer
branch
from
53d362f to
669b658
Compare
vladfrangu
force-pushed
the
ts/puppeteer
branch
from
669b658 to
5cfe987
Compare
szmarczak
reviewed
Aug 9, 2021
szmarczak
reviewed
Aug 9, 2021
Co-authored-by: Szymon Marczak <36894700+szmarczak@users.noreply.github.com>
szmarczak
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC: @pocesar @B4nan @mnmkng
This PR also updates TS, and disables npm 7's stupid peer dependency changes