Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: convert playwright to TS #38

Merged
merged 3 commits into from
Aug 10, 2021
Merged

refactor: convert playwright to TS #38

merged 3 commits into from
Aug 10, 2021

Conversation

vladfrangu
Copy link
Member

Needs #37 first, will rebase after 👍

@vladfrangu vladfrangu requested review from pocesar, B4nan and mnmkng August 5, 2021 09:01
@vladfrangu vladfrangu marked this pull request as ready for review August 10, 2021 11:24
@vladfrangu vladfrangu requested a review from szmarczak August 10, 2021 11:24
szmarczak
szmarczak approved these changes Aug 10, 2021
View reviewed changes
Copy link
Contributor

@szmarczak szmarczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnmkng mnmkng merged commit 8e8db23 into apify:master Aug 10, 2021
@vladfrangu vladfrangu mentioned this pull request Aug 13, 2021
Closed
@B4nan B4nan mentioned this pull request Aug 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szmarczak szmarczak szmarczak approved these changes

@pocesar pocesar Awaiting requested review from pocesar

@B4nan B4nan Awaiting requested review from B4nan

@mnmkng mnmkng Awaiting requested review from mnmkng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vladfrangu @szmarczak @mnmkng