Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update package.json peerDependencies (#6594)" #6605

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Conversation

hwillson
Copy link
Member

This reverts commit 831b7ab.

We rushed this in just before the AC3 launch without fully thinking through the consequences. From #6594 (comment):

I think you ought to reconsider this change. See this explanation. It's also been rejected in other prominent repos like React.

tl;dr: it's likely that at some point in the future, a new major version of at least one of these peer dependencies will be released that isn't compatible with Apollo Client's use of it. This will cause Apollo Client to break without warning if the consumer upgrades this dependency. It's essentially the same reason why one wouldn't want to use >= for regular dependencies.

Thanks for catching this @billyjanitsch!

Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjamn benjamn merged commit ecafe87 into master Jul 15, 2020
@benjamn benjamn deleted the revert-6594 branch July 15, 2020 14:51
benjamn added a commit that referenced this pull request Jul 15, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants