Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update peerDependencies in package.json #19356

Closed
wants to merge 19 commits into from
Closed

Update peerDependencies in package.json #19356

wants to merge 19 commits into from

Conversation

MichaelDeBoey
Copy link
Contributor

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d970c91:

Sandbox Source
React Configuration

@sizebot
Copy link

sizebot commented Jul 14, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against d970c91

@sizebot
Copy link

sizebot commented Jul 14, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against d970c91

rickhanlonii
rickhanlonii requested changes Jul 15, 2020
View reviewed changes
Copy link
Member

@rickhanlonii rickhanlonii left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These packages are not known or guaranteed to work with the next major version as a peerDependency.

@rickhanlonii
Copy link
Member

rickhanlonii commented Jul 15, 2020 •
edited
Loading

@MichaelDeBoey is this something you're scripting (I see the same to other projects) or am I missing something?

@MichaelDeBoey
Copy link
Contributor Author

@rickhanlonii It takes less time to do it manually I think, so I didn't script it
I just wanted to update this

@gaearon
Copy link
Collaborator

gaearon commented Jul 15, 2020

This isn't right. The whole purpose of the peerDeps is to show we're not necessarily compatible with future majors.

@gaearon gaearon closed this Jul 15, 2020
@billyjanitsch billyjanitsch mentioned this pull request Jul 15, 2020
Merged
@MichaelDeBoey MichaelDeBoey deleted the patch-2 branch July 15, 2020 14:29
@hwillson hwillson mentioned this pull request Jul 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickhanlonii rickhanlonii rickhanlonii requested changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MichaelDeBoey @sizebot @rickhanlonii @gaearon @facebook-github-bot