This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 786
Replace duplicate ObservableQueryFields types defined in apollo-client #2281
Merged
hwillson
merged 4 commits into
apollographql:master
from
skovy:skovy/reuse-apollo-client-query-types
Aug 22, 2018
Merged
Replace duplicate ObservableQueryFields types defined in apollo-client #2281
hwillson
merged 4 commits into
apollographql:master
from
skovy:skovy/reuse-apollo-client-query-types
Aug 22, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwillson
approved these changes
Aug 22, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great @skovy - thanks very much!
tgriesser
added a commit
to tgriesser/react-apollo
that referenced
this pull request
Aug 27, 2018
Related to changes in apollographql#2281, because variables was previously declared on the type it wasn't necessary before
tgriesser
added a commit
to tgriesser/react-apollo
that referenced
this pull request
Aug 28, 2018
Related to changes in apollographql#2281, because variables was previously declared on the type it wasn't necessary before
williamboman
added a commit
to williamboman/react-apollo
that referenced
this pull request
Aug 29, 2018
* master: (112 commits) chore(deps): update dependency danger to v3.8.8 chore(deps): update dependency enzyme to v3.5.0 chore(deps): update dependency apollo-client to v2.4.1 chore(deps): update dependency apollo-cache-inmemory to v1.2.9 chore(deps): update dependency apollo-cache to v1.1.16 chore(deps): update dependency @types/react to v16.4.12 chore(deps): update dependency rollup-plugin-commonjs to v9.1.6 chore(deps): update dependency @types/node to v10.9.2 chore(deps): update dependency react-scripts to v1.1.5 chore(deps): update dependency ts-jest to v23.1.4 Avoid importing lodash directly (apollographql#2045) type graphql.options.skip HOC property (apollographql#2208) Replace duplicate ObservableQueryFields types defined in apollo-client (apollographql#2281) Make mock links mock parameter readonly (apollographql#2284) test-utils: allow passing a custom cache object to `MockedProvider` (apollographql#2254) Query: Fix data is undefined on error (apollographql#1983) Don't mutate options object when calculating variables from props (apollographql#1968) Feature: add onSubscriptionData callback to <Subscription> (apollographql#1966) Changelog update Example of a mutation including tests (apollographql#1998) ...
hwillson
pushed a commit
that referenced
this pull request
Oct 2, 2018
Related to changes in #2281, because variables was previously declared on the type it wasn't necessary before
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
react-apollo
andapollo-client
.These types were originally defined in #1617 (see here) and many have since been back-ported to
apollo-client
(see apollographql/apollo-client#3140)