Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Make mock links mock parameter readonly #2284

Merged
merged 3 commits into from
Aug 22, 2018
Merged

Make mock links mock parameter readonly #2284

merged 3 commits into from
Aug 22, 2018

Conversation

amacleay
Copy link
Contributor

@amacleay amacleay commented Aug 14, 2018 •
edited by hwillson
Loading

Since mocks are not modified at runtime, allow readonly mock lists,

Fixes #2283

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • If this was a change that affects the external API used in GitHunt-React, update GitHunt-React and post a link to the PR in the discussion.

@amacleay
Make mock links mock parameter readonly
073b669 
Since mocks are not modified at runtime, allow readonly mock lists
@hwillson hwillson added the todo label Aug 21, 2018
@hwillson hwillson self-assigned this Aug 21, 2018
@hwillson hwillson added in-progress and removed todo labels Aug 22, 2018
hwillson
hwillson approved these changes Aug 22, 2018
View reviewed changes
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amacleay - let's do this! 👍

@hwillson hwillson merged commit a6021bb into apollographql:master Aug 22, 2018
williamboman added a commit to williamboman/react-apollo that referenced this pull request Aug 29, 2018
@williamboman
Merge branch 'master' into react-apollo-mockedprovider-fix
7cf750d 
* master: (112 commits)
  chore(deps): update dependency danger to v3.8.8
  chore(deps): update dependency enzyme to v3.5.0
  chore(deps): update dependency apollo-client to v2.4.1
  chore(deps): update dependency apollo-cache-inmemory to v1.2.9
  chore(deps): update dependency apollo-cache to v1.1.16
  chore(deps): update dependency @types/react to v16.4.12
  chore(deps): update dependency rollup-plugin-commonjs to v9.1.6
  chore(deps): update dependency @types/node to v10.9.2
  chore(deps): update dependency react-scripts to v1.1.5
  chore(deps): update dependency ts-jest to v23.1.4
  Avoid importing lodash directly (apollographql#2045)
  type graphql.options.skip HOC property (apollographql#2208)
  Replace duplicate ObservableQueryFields types defined in apollo-client (apollographql#2281)
  Make mock links mock parameter readonly (apollographql#2284)
  test-utils: allow passing a custom cache object to `MockedProvider` (apollographql#2254)
  Query: Fix data is undefined on error (apollographql#1983)
  Don't mutate options object when calculating variables from props (apollographql#1968)
  Feature: add onSubscriptionData callback to <Subscription> (apollographql#1966)
  Changelog update
  Example of a mutation including tests (apollographql#1998)
  ...
@amacleay amacleay deleted the readonly-mock-links branch September 10, 2018 18:56
@dependencies dependencies bot mentioned this pull request Sep 26, 2018
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hwillson hwillson hwillson approved these changes

Assignees

@hwillson hwillson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MockedProvider's mocks prop need not be mutable
2 participants
@amacleay @hwillson