Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate and package licenses.html file #164

Merged
merged 13 commits into from
Nov 23, 2021
Merged

Conversation

o0Ignition0o
Copy link
Contributor

@o0Ignition0o o0Ignition0o commented Nov 19, 2021

feat: generate and package licenses.html file

fixes #36

This commit allows us to generate a licenses.html, file, that contains all of the licenses our dependencies use. It is based on cargo-about:

  • update xtask check-compliance to run cargo-about alongside cargo-deny, and bail if the licenses.html fils is not up to date.
  • update CI to install cargo-about when checking for lints / compliance.
  • update DEVELOPMENT.md to let users know how to run cargo xtask lint and cargo xtask check-compliance, as well as how to install the required dependencies.
  • add licenses.html to the tarballs when building a release artefact.

@o0Ignition0o
Copy link
Contributor Author

o0Ignition0o commented Nov 19, 2021

Here's the output if the licenses.html file is not in sync:

image

Here's the CI output if the file is in sync:

image

@o0Ignition0o o0Ignition0o changed the title early wip, generate license file feat: generate and package licenses.html file Nov 19, 2021
@o0Ignition0o o0Ignition0o marked this pull request as ready for review November 19, 2021 12:31
@o0Ignition0o o0Ignition0o self-assigned this Nov 19, 2021
xtask/src/commands/check.rs Outdated Show resolved Hide resolved
xtask/src/commands/check.rs Outdated Show resolved Hide resolved
xtask/src/commands/check.rs Outdated Show resolved Hide resolved
xtask/src/commands/check.rs Outdated Show resolved Hide resolved
o0Ignition0o and others added 6 commits November 19, 2021 16:56
@o0Ignition0o o0Ignition0o mentioned this pull request Nov 22, 2021
@o0Ignition0o o0Ignition0o merged commit d826844 into main Nov 23, 2021
@o0Ignition0o o0Ignition0o deleted the igni/generate_credits branch November 23, 2021 08:54
tinnou pushed a commit to Netflix-Skunkworks/router that referenced this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate license file from dependencies
2 participants