-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generate and package licenses.html file #164
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dencies in CI so this check passes as well
o0Ignition0o
changed the title
early wip, generate license file
feat: generate and package licenses.html file
Nov 19, 2021
o0Ignition0o
requested review from
cecton,
Geal,
BrynCooke,
abernix and
garypen
November 19, 2021 12:30
cecton
approved these changes
Nov 19, 2021
Co-authored-by: Cecile Tonglet <cecile.tonglet@cecton.com>
Co-authored-by: Cecile Tonglet <cecile.tonglet@cecton.com>
Co-authored-by: Cecile Tonglet <cecile.tonglet@cecton.com>
Merged
tinnou
pushed a commit
to Netflix-Skunkworks/router
that referenced
this pull request
Oct 16, 2023
…llographql#164) Similar spirit as previous PR for [2.1.0]. [2.1.0]: apollographql/federation-rs#161 [2.1.1]: apollographql/federation#2122
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: generate and package licenses.html file
fixes #36
This commit allows us to generate a licenses.html, file, that contains all of the licenses our dependencies use. It is based on cargo-about:
xtask check-compliance
to run cargo-about alongside cargo-deny, and bail if the licenses.html fils is not up to date.cargo-about
when checking for lints / compliance.cargo xtask lint
andcargo xtask check-compliance
, as well as how to install the required dependencies.licenses.html
to the tarballs when building a release artefact.