Remove grpcio #153
Remove grpcio #153
Conversation
Geal
force-pushed
the
remove-grpcio
branch
3 times, most recently
from
5d79e66
to
3a84c54
Compare
Geal
force-pushed
the
remove-grpcio
branch
3 times, most recently
from
7437492
to
fafa071
Compare
|
❌ Deploy Preview for apollo-router-docs failed. 🔨 Explore the source changes: fafa071 🔍 Inspect the deploy log: https://app.netlify.com/sites/apollo-router-docs/deploys/6197afcc8015120007aa6ac3 |
|
tbh we could just remove the tls feature and have it always built with otlp-grpc. It increases the produced binary by only 2MB (1MB when stripped) and does not increase the requirements on the system: it load the same set of dlls as a router built without the tls feature |
|
|
so the License checker apparently did not test with all the features. @o0Ignition0o how should we add the license for ring since it's not well detected? |
|
Ok this has just been merged, CI should pass once you rebase! |
Geal
force-pushed
the
remove-grpcio
branch
2 times, most recently
from
e541826
to
b77d0ad
Compare
| #[serde(deny_unknown_fields)] | ||
| pub struct Exporter { | ||
| pub struct TonicExporter { |
We do not need to use two different gRPC implementations for OTLP, and grpcio greatly increases the compilation times and CI cache size, so we're choosing to use tonic instead * make the OTLP exporters non exclusive We should be able to build a router with both OTLP/HTTP and OTLP/gRPC exporters update the opentelemetry dependency to get access to SpanExporterBuilder that was not public before
* The cargo feature name should match the actual feature, not the
implementation detail
* allow empty configuration under http or grpc exporter
with this we can configure the HTTP or gRPC exporter while using default
values, like:
opentelemetry:
otlp:
tracing:
exporter:
http:
…defer-in-introspection support defer in introspection queries
Fix #150
supplant #147
This PR includes:
otlp-tonicfeature tootlp-grpctlsfeature forcesotlp-grpcsince it cannot be used independently (maybe we could merge them?)