-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor model.rs & QueryPlanner related stuff #233
Conversation
could we hold off on big file movements for a while after this PR lands? It has been happening often recently, and it is getting hard to follow, especially if we are trying to modify the same files in other pull requests. It also does not help for reviews when there are other changes during the move. Like, in this commit 7524bc5, ath the same time there's the change to use |
@Geal all things are interconnected. I made the list of changes I did in the PR description. |
@Geal it's mostly just moving things around and replacing some |
yes I am not saying we should never move things around. But in the past 2 weeks there's been #203 #205 #166 #153 and #140 moving code around. This is a lot, and I wish the code organisation would settle down a bit, because it's hard to review, it's annoying to integrate when we're working concurrently, and going through the code's history and understand past changes is arduous |
Yes true... Though #203 is a noop. When I updated my branches after that one got merged, the merge was almost automatic locally. Maybe you are rebasing a lot? |
I'm a git monkey, I jump from branch to branch all day 🙈 |
Merging this for now as it can conflict easily with other PRs. Don't hesitate to give feedback later |
Cloning the full entry results in leaks. fixes: #233
Changes
Cleanup snapshots: some snapshots files were unused and some had path not update. I made another PR for this Cleanup snapshots #234PlannerResult
instead ofQueryPlanner
: this newPlannerResult
enum can detect only the kindQueryPlanner
and will return a specific error on parsing if something else is returned by the router bridge.model.rs
toquery_planner/mod.rs
and make them privateSelection
private and move all the logic around "selection" of the query planner toselection.rs
(it's kinda big, it deserves its own file)select()
onResponse
toselection.rs
and make it privateapollo-router/tests/fixtures/query_plan.json
because it was not used anymoreRelated to #234
Related to #233