add chromedriverPorts cap which allows specifying multiple ports or a range #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh, also deprecate |
|
while i was in there i also removed a discrepancy where the bootstrapPort opt was only a CLI opt and not a desired cap. now it can be either like all the rest. |
jlipps
requested review from
imurchie and
KazuCocoa
and removed request for
imurchie
KazuCocoa
reviewed
Apr 4, 2019
lib/commands/context.js
Outdated
| // defining a port range | ||
| log.debug(`Finding a free port for chromedriver using spec ${JSON.stringify(opts.chromedriverPorts)}`); | ||
| let foundPort = null; | ||
| for (let potentialPort of opts.chromedriverPorts) { |
lib/commands/context.js
Outdated
| @@ -265,16 +265,64 @@ async function setupExistingChromedriver (chromedriver) { | |||
| return chromedriver; | |||
| } | |||
|
|
|||
| async function getChromedriverPort (opts) { | |||
| opts.chromeDriverPort = await getPort(); | ||
| log.debug(`A port was not given, using random port: ${opts.chromeDriverPort}`); | ||
| if (opts.chromeDriverPort) { | ||
| log.warn(`The 'chromeDriverPort' capability is deprecated. Please use 'chromedriverPort' instead`); |
|
ok, feedback addressed. this PR now also depends on appium/appium-base-driver#314 |
KazuCocoa
approved these changes
Apr 4, 2019
… range this helps support the multiple webview case
… for getChromedriverPort
jlipps
force-pushed
the
jlipps/chromedriverport
branch
from
02d0e96 to
49155e4
Compare
|
a note need to update after this: |
|
published in 4.14.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this helps support the multiple webview case, and would provide a supported 'workaround' for e.g. appium/appium#11820