This repository has been archived by the owner on Oct 25, 2023. It is now read-only.
add isArray to cap validation strategies #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
travis failure is due to what looks like an unrelated flake. i also ran into this locally apart from this PR. how do we have flakes in our unit tests? |
mykola-mokhnach
approved these changes
Apr 4, 2019
|
There is one unstable test... |
|
i'll try to fix the test in another PR, not sure why it's not working |
|
published in 3.15.5. test hopefully fixed in #315 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also add a log line i found helpful