This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
fix: Stop ignoring result for element location/size #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'ignoreResult' flag was causing the result to not be sent back to the renderer process. This was done because there's some cases where we don't want the result to be displayed using "notification" but this is a problem for highlighting an element because it wasn't getting the result. This changes it so that 'ignoreResult' still sends the result back to the renderer but skips the notification if it's 'ignoreResult=true'.
app/renderer/actions/shared.js
Outdated
| @@ -23,7 +23,7 @@ export function bindClient () { | |||
|
|
|||
| const truncatedResult = _.truncate(JSON.stringify(res), {length: 2000}); | |||
|
|
|||
| if (!_.isNull(res) && !_.isUndefined(res)) { | |||
| if (!_.isNull(res) && !_.isUndefined(res) && !resp.ignoreResult) { | |||
There was a problem hiding this comment.
util.hasValue(res) && !resp.ignoreResult
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'ignoreResult' flag was causing the result to not be sent back to the renderer process. This was done because there's some cases where we don't want the result to be displayed using "notification" but this is a problem for highlighting an element because it wasn't getting the result.
This changes it so that 'ignoreResult' still sends the result back to the renderer but skips the notification if it's 'ignoreResult=true'.