Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

fix: Stop ignoring result for element location/size #922

Merged
merged 2 commits into from
Apr 2, 2019
Merged

fix: Stop ignoring result for element location/size #922

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6f0d14
fix: Stop ignoring result for element location/size
dpgraham Apr 1, 2019
3de1dcf
PR fix
dpgraham Apr 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions app/main/appium.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,13 +300,10 @@ function connectClientMethodListener () {
}
}

if (ignoreResult) {
res = {};
}

renderer.send('appium-client-command-response', {
...res,
methodName,
ignoreResult,
uuid,
});
}
Expand Down
2 changes: 1 addition & 1 deletion app/renderer/actions/shared.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export function bindClient () {

const truncatedResult = _.truncate(JSON.stringify(res), {length: 2000});

if (!_.isNull(res) && !_.isUndefined(res)) {
if (!_.isNull(res) && !_.isUndefined(res) && !resp.ignoreResult) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

util.hasValue(res) && !resp.ignoreResult

notification.success({
message: i18n.t('methodCallResult', {methodName}),
description: i18n.t('commandWasReturnedWithResult', {result: truncatedResult}),
Expand Down
45 changes: 12 additions & 33 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.