Features/actor lineage #4136
Merged
Features/actor lineage #4136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flow/flow.h
Outdated
| // A user should implement this for any type | ||
| // within the properies class. | ||
| template<class Value> | ||
| bool isSet(Value Derived::*member) { |
There was a problem hiding this comment.
Should this function ever be called?
this has to be implemented by subclasses
Makes me wonder if it shouldn't ever be called, in which case maybe we can ASSERT(false) here
There was a problem hiding this comment.
probably - I still wonder how we could provide a default implementation for this... But all solutions involve a lot of template-code (and I don't want to do that in flow.h...)
fdbrpc/RoleLineage.h
Outdated
| static StringRef name; | ||
| ProcessClass::ClusterRole role = ProcessClass::NoRole; | ||
|
|
||
| bool isSet(ProcessClass::ClusterRole RoleLineage::*member) { |
There was a problem hiding this comment.
I don't understand this syntax. Do you have a reference I could look at for this (I'm not exactly sure what to google). What type does member have?
There was a problem hiding this comment.
This is the pointer to member syntax (we use this in loadBalance). The only thing I can find is MS documentation: https://docs.microsoft.com/en-us/cpp/cpp/pointer-to-member-operators-dot-star-and-star?view=msvc-160 (but if you google it you can also find some stack overflow questions that are useful)
ActorLineageSet Implementation
…entd add default constructor to Sample
Check validity of ActorLineage
…entd fix special keyspace register
Fixes the following issues: 1. Use the right index when initializing the WriteOnlySet's vector of atomics. Also switch to std::atomic_init to initialize each atomic in the vector (cannot default construct the atomics in the vector because std::atomic does not have a copy constructor). 2. Add failure check for when items cannot be inserted into the WriteOnlySet due to capacity constraints. This situation occurs when `copy` is not called on the WriteOnlySet, such as when sampling is disabled. The `copy` function is what clears the WriteOnlySet. 3. Remove a global config feature I added to update the ClientDBInfo object used by the global config listener function. This needs more investigation, but the effect of this change could be that global config changes are not correctly recognized on fdbserver processes. 4. Add various ASSERTs to verify data in WriteOnlySet.
This is causing problems with the 5.2.0 restarting test. Removing this line disables fdbserver processes from receiving global config updates, instead requiring a restart to see them.
Fixes/fix simulation
AWS CodeBuild CI Report
|
AWS CodeBuild CI Report
|
AWS CodeBuild CI Report
|
sfc-gh-ljoswiak
approved these changes
May 3, 2021
sfc-gh-ljoswiak
added a commit
to sfc-gh-ljoswiak/foundationdb
that referenced
this pull request
May 11, 2021
sfc-gh-ljoswiak
added a commit
to sfc-gh-ljoswiak/foundationdb
that referenced
this pull request
May 11, 2021
sfc-gh-ljoswiak
added a commit
that referenced
this pull request
May 12, 2021
…lease-7.0 Revert "Merge pull request #4136 from sfc-gh-mpilman/features/actor-l…
sfc-gh-ljoswiak
added a commit
that referenced
this pull request
May 12, 2021
Revert "Merge pull request #4136 from sfc-gh-mpilman/features/actor-l…
This was referenced Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is resolves #...
Changes in this PR:
General guideline:
Please verify that all things listed below were considered and check them. If an item doesn't apply to this type of PR (for example a documentation change doesn't need to be performance tested), you should make a
strikethrough(markdown syntax:~~strikethrough~~). More infos on the guidlines can be found here.Style
git clang-format).Performance
std::vectorvsVectorRef).SlowTasktraces.Testing
ASSERT,ASSERT_WE_THINK, andTESTmacros are added in appropriate places.