Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #4136 from sfc-gh-mpilman/features/actor-l… #4802

Merged
merged 1 commit into from
May 12, 2021

Conversation

sfc-gh-ljoswiak
Copy link
Collaborator

…ineage"

This reverts commit da41534, reversing
changes made to e630090.

Was causing a large (~30%) performance regression. Will revert to stop blocking performance testing on master.

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or master if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

…tor-lineage"

This reverts commit da41534, reversing
changes made to e630090.
@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: 4ea760b
  • Result: SUCCEEDED
  • Build Logs (available for 7 days)

@sfc-gh-ljoswiak
Copy link
Collaborator Author

Passed 10k tests run on Joshua.

@sfc-gh-ljoswiak sfc-gh-ljoswiak marked this pull request as ready for review May 11, 2021 15:52
@sfc-gh-ljoswiak sfc-gh-ljoswiak merged commit 6499fa1 into apple:master May 12, 2021
sfc-gh-ljoswiak added a commit to sfc-gh-ljoswiak/foundationdb that referenced this pull request Jun 3, 2021
…or-lineage"

This reverts commit 6499fa1, reversing
changes made to 1512631.
sfc-gh-ljoswiak added a commit to sfc-gh-ljoswiak/foundationdb that referenced this pull request Jun 4, 2021
…or-lineage"

This reverts commit 6499fa1, reversing
changes made to 1512631.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants