Feature/anxr 202 tooltip #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
still need to write tests |
| /** | ||
| * Indicates whether the ToolTip will render or not. Defaults to `true`. | ||
| */ | ||
| isExpanded: bool, |
There was a problem hiding this comment.
i just kept this since it maps to ContextMenu's isExpanded, but should it be isShown here instead?
|
|
||
| const matcher = _.matches({ direction, alignment }); | ||
|
|
||
| if (matcher({ direction: UP, alignment: START })) { |
There was a problem hiding this comment.
it would be even more readable if it was called matches or isMatch instead of matcher
There was a problem hiding this comment.
didn't want to clash with _.matches, and wanted to make it clear it's a function. 🤷
| ...flyOutStyle, | ||
| maxWidth: flyOutMaxWidth || flyOutStyle.maxWidth || 200 | ||
| }} | ||
| className={flyOutCx('&', { [`${className}-FlyOut`]: className }, `&-${direction}`, `&-${alignment}`, `&-${kind}`)} |
| @@ -205,7 +205,7 @@ const ToolTip = createClass({ | |||
|
|
|||
| return ( | |||
| <ContextMenu | |||
| className={cx('&', '&-base', className)} | |||
| className={className} | |||
There was a problem hiding this comment.
this should still have the ToolTip classname on it at the least:
className={cx('&', className)}
| {isCloseable ? <CrossIcon onClick={this.handleClose} className={flyOutCx('&-close')}/> : null} | ||
| <h2 className={flyOutCx('&-title')}>{title}</h2> | ||
| {isCloseable ? <CrossIcon onClick={this.handleClose} className={flyOutCx('&-Close')}/> : null} | ||
| <h2 className={flyOutCx('&-Title')}>{title}</h2> |
sodiumjoe
force-pushed
the
feature/ANXR-202-tooltip
branch
from
906ccc4
to
c8ad6fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
commonat minimum)semver-labelskindprop)isCloseable/onClosecloses #234