-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/anxr 202 tooltip #247
Merged
Merged
Changes from 11 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
ddb1446
add 'right' and 'left' directions to ContextMenu
sodiumjoe fcc5e02
add right and left directions, and `alignment` prop
sodiumjoe fd38ac3
add alignment: center
sodiumjoe 32be4e5
add directionOffset and alignmentOffset
sodiumjoe cae5f27
fix directionOffset direction for direcion: down
sodiumjoe 3cc04b1
improve ToolTip examples
sodiumjoe bc1864b
add getAlignmentOffset prop
sodiumjoe 9ec16e5
position and style ToolTip
sodiumjoe a601e23
move getPosition out of component def
sodiumjoe 867eaf5
add state wrapper to ToolTip
sodiumjoe 584e161
Merge branch 'release/1.0.0' into feature/ANXR-202-tooltip
sodiumjoe 4e703f8
move banner to `Communication` category
sodiumjoe 9fc344c
remove unnecessary initial state
sodiumjoe 0325c71
uncomment static directions example
sodiumjoe f2c1633
fix typo
sodiumjoe e7b9f31
fix lint errors
sodiumjoe 3ad9cd8
add tooltip reducers tests
sodiumjoe acf895c
refactor onX convention test for better error output
sodiumjoe 4e805a4
exempt getAlignmentOffset from onX convention
sodiumjoe 3500090
refactor scoped class test for better errors
sodiumjoe ef34797
remove intermediate div
sodiumjoe 445389c
scope direction/alignment classes
sodiumjoe 8720841
add default maxWidth to ToolTip flyout
sodiumjoe 3baf1f3
follow component class name convention
sodiumjoe 86d9f60
add tests for ToolTip
sodiumjoe 542c5ba
fix class name
sodiumjoe e4cb665
add isCloseable/onClose props to ToolTip
sodiumjoe 7b731bf
add `kind` prop to ToolTip and clean up less
sodiumjoe c30a68e
change default maxWidth of ToolTip
sodiumjoe 52f5778
add examples for `kind`, `isCloseable`
sodiumjoe 6a07f32
style tweaks for ToolTip
sodiumjoe 0143d3a
code review feedback
sodiumjoe 43b3b8c
fix indents
sodiumjoe 60ceb3c
Merge branch 'release/1.0.0' into feature/ANXR-202-tooltip
sodiumjoe 8ec5bcc
className tweaks to ToolTip
sodiumjoe 491de66
Merge branch 'release/1.0.0' into feature/ANXR-202-tooltip
sodiumjoe c8ad6fe
code review feedback on ToolTip
sodiumjoe d571cb2
fix test
sodiumjoe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, very readable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be even more readable if it was called
matches
orisMatch
instead ofmatcher
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't want to clash with
_.matches
, and wanted to make it clear it's a function. 🤷