Fixes incorrect site monthly metrics course completion data #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Site monthly metrics course completions API endpoint was retrieving total site users erroneously. This was caused by 'copy/paste of the viewset method and the mismatch never got caught. This is a good reason why testing data quality on top of basic code coverage is important for the API views * https://appsembler.atlassian.net/browse/RED-1061
OmarIthawi
approved these changes
Jun 8, 2020
melvinsoft
approved these changes
Jun 11, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Site monthly metrics course completions API endpoint was retrieving
total site users erroneously. This was caused by 'copy/paste of the
viewset method and the mismatch never got caught. This is a good reason
why testing data quality on top of basic code coverage is important for
the API views