Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build 0.3.9 #225

Closed
wants to merge 2 commits into from
Closed

Build 0.3.9 #225

wants to merge 2 commits into from

Conversation

johnbaldwin
Copy link
Contributor

DRAFT PR to run tests on build branch with hot fix cherry pick of

bbefd3e

@johnbaldwin
Added compiled frontend assets to build-0.3.9
e0e2bf4
@johnbaldwin
Fixed LearnerCourseGradesDetailsSerializer.get_progress_data method
63acdbe 
If there aren't any matching LearnerCourseGradeMetrics records matching
the filtering criteria then an exception is raised and trapped,
triggering an error log.

This does not change the behvior of the method. What is does is reduce
logging noise to the log files and also does not create a
`PipelineError` table log enty, saving database space
@melvinsoft
Copy link
Contributor

@johnbaldwin Maybe I'm looking wrong, but I'm not seeing this fix here: #219

I know isn't related to performance, but it would be great to bundle it in case is not.

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2020 •
edited
Loading

Codecov Report

Merging #225 into master will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage   91.31%   91.19%   -0.12%     
==========================================
  Files          37       38       +1     
  Lines        1876     2169     +293     
==========================================
+ Hits         1713     1978     +265     
- Misses        163      191      +28
Impacted Files Coverage Δ
figures/serializers.py 94.37% <100.00%> (-1.16%) ⬇️
figures/migrations/0010_site_monthly_metrics.py 93.33% <0.00%> (-6.67%) ⬇️
figures/metrics.py 87.58% <0.00%> (-0.40%) ⬇️
figures/pipeline/enrollment_metrics.py 98.33% <0.00%> (ø)
figures/views.py 92.95% <0.00%> (+1.21%) ⬆️
figures/pipeline/course_daily_metrics.py 96.04% <0.00%> (+1.21%) ⬆️
figures/sites.py 67.46% <0.00%> (+2.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0293795...63acdbe. Read the comment docs.

@johnbaldwin
Copy link
Contributor Author

@melvinsoft I only picked the critical fix needed for Tahoe prod. The other commits are specific to ginkgo or testing

@melvinsoft
Copy link
Contributor

@johnbaldwin Ok, thanks! Got it.

@thraxil
Copy link
Contributor

thraxil commented Jun 22, 2020

What is the status on this? It's still a Draft PR but hasn't changed in 10 days and AFAICT, 3.10 is already released.

thraxil
thraxil suggested changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@thraxil thraxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking this until it's made clear whether this PR is still needed or not.

@johnbaldwin
Copy link
Contributor Author

@thraxil Yeah, I can get rid of this one. Thanks for the nudge

@johnbaldwin johnbaldwin deleted the build-0.3.9 branch February 4, 2022 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thraxil thraxil thraxil requested changes

@melvinsoft melvinsoft melvinsoft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johnbaldwin @melvinsoft @codecov-commenter @thraxil