Allow escaping commas and colons in source bind path with the followi… #6008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclerget
force-pushed
the
issue-5923-5959
branch
2 times, most recently
from
59de124 to
789f681
Compare
|
@cclerget is this ready for review? You weren't thinking of getting this in to 3.8.0, were you? |
|
@DrDaveD Not 3.8.0, I created a 3.8.1 milestone and put this fix and issues in the 3.8.1 milestone. For this PR I forgot to add few e2e tests which I will add soon |
…ng syntax: - `singularity shell -B /tmp/comma\\,separated_dir:/data image` - `singularity shell -B "/tmp/comma\,separated_dir":/data image` - `singularity shell -B /tmp/colon\\:sep_dir:/data image` - `singularity shell -B /tmp/"colon\:sep_dir":/data image` - Fixes apptainer#5923 - Fixes apptainer#5959
DrDaveD
approved these changes
Jun 28, 2021
cclerget
added a commit
to cclerget/singularity
that referenced
this pull request
Sep 4, 2021
…out destination two times
DrDaveD
added a commit
that referenced
this pull request
Sep 4, 2021
Fix a regression introduced by #6008 adding bind mounts without destination two times
kmuriki
added a commit
that referenced
this pull request
Sep 8, 2021
…ut destination two times" This reverts commit 26a215e.
kmuriki
pushed a commit
to kmuriki/singularity
that referenced
this pull request
Sep 8, 2021
…out destination two times
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Pull Request (PR):
Allow escaping commas and colons in source bind path with the following syntax:
singularity shell -B /tmp/comma\\,separated_dir:/data imagesingularity shell -B "/tmp/comma\,separated_dir":/data imagesingularity shell -B /tmp/colon\\:sep_dir:/data imagesingularity shell -B "/tmp/colon\:sep_dir":/data imageThis fixes or addresses the following GitHub issues:
Before submitting a PR, make sure you have done the following:
make checkand tested this PR locally with amake test, andmake testallif possible (see CONTRIBUTING.md).