Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long form --mount to support special chars in bind mount paths etc. #118

Closed
dtrudg opened this issue Jul 2, 2021 · 1 comment · Fixed by #324
Closed

Long form --mount to support special chars in bind mount paths etc. #118

dtrudg opened this issue Jul 2, 2021 · 1 comment · Fixed by #324
Labels
enhancement New feature or request roadmap Features / changes that are scheduled to be implemented

Comments

@dtrudg
Copy link
Member

dtrudg commented Jul 2, 2021

Is your feature request related to a problem? Please describe.
A path containing a : cannot be bind mounted.

Describe the solution you'd like
One approach is an escaping pattern as in apptainer/singularity#6008 - but the changes introduce further deep nested logic in the bind mount parsing.

It may be useful to consider how docker does this with a verbose --mount flag that uses type=,source=,destination= to avoid escaping problems.

moby/moby#8604

See commentary on the hpcng issue: apptainer/singularity#5923

@dtrudg dtrudg added enhancement New feature or request maybe Features / changes that maybe implemented in future, depending on need & resources labels Jul 2, 2021
@dtrudg
Copy link
Member Author

dtrudg commented Jul 22, 2021

Convinced now that using a long form --mount syntax is the way to go here. We will gain some basic compatibility with Docker, for tools/manual use where it's advantageous to have common syntax for bind mounts when calling docker and Singularity.

We can also in future look at supporting the propagation and recursion options Docker exposes, and allowing type=tmpfs mounts as Docker does, if these would be useful to people.

Please let me know here if you think I'm misguided :-)

@dtrudg dtrudg added roadmap Features / changes that are scheduled to be implemented and removed maybe Features / changes that maybe implemented in future, depending on need & resources labels Jul 22, 2021
@dtrudg dtrudg added this to the SingularityCE 3.9.0 milestone Jul 22, 2021
@dtrudg dtrudg changed the title Consider solution for : in bind mount paths Long form --mount to support special chars in bind mount paths etc. Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request roadmap Features / changes that are scheduled to be implemented
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant