-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add time range to tenants #120
Conversation
4e86ef8
to
49647a2
Compare
Draft since this does not yet handle existing tenants where the time is outside the time range. When a tenant is created, the time of the run is used ( Idea: @bastjan wdyt? |
related PR: appuio/appuio-io-docs#145 |
49647a2
to
2d1b921
Compare
Decided to fail if there is an overlap in the time range for a tenant instead of covering small edge-cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original unique index needs dropping. Otherwise LGTM 👍
Also don't forget the invoice part, from my quick reading it should just work™️ but to feel better i'd add a split timerange to one of the invoice tests https://github.com/appuio/appuio-cloud-reporting/blob/master/pkg/invoice/invoice_test.go. |
4f28b0d
to
160a601
Compare
I forgot our discussions already but did we not say we'll create tenants from query timestamp to infinity when upserting them? 🙈 |
I think we decided on the default of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must be rebased, otherwise LGTM
Introduces a time range for the source/target links of a tenant.
160a601
to
4111e0e
Compare
Summary
Introduces a time range for the source/target links of a tenant.
Checklist
bug
,enhancement
,documentation
,change
,breaking
,dependency
as they show up in the changelog