Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add query for Redis by VSHN #129

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Add query for Redis by VSHN #129

merged 2 commits into from
Mar 10, 2023

Conversation

Kidswiss
Copy link
Contributor

@Kidswiss Kidswiss commented Mar 9, 2023 •
edited
Loading

Summary

  • Add a query to get usage for Redis by VSHN instances
  • AppCat by VSHN services will all use almost the same query for billing. Added ability to render the changes via gotemplate.

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

@Kidswiss Kidswiss marked this pull request as draft March 9, 2023 10:32
@Kidswiss Kidswiss force-pushed the add/redis branch 3 times, most recently from 5bca113 to 4e07729 Compare March 9, 2023 12:19
@Kidswiss Kidswiss added the enhancement New feature or request label Mar 9, 2023
@Kidswiss Kidswiss marked this pull request as ready for review March 9, 2023 14:05
@Kidswiss Kidswiss requested review from glrf and bastjan March 9, 2023 14:05
bastjan
bastjan approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@bastjan bastjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm not sure though how much more logic should go into seeds before we properly do migrations of seeded data.

pkg/db/seeds.go Outdated Show resolved Hide resolved
@Kidswiss
Copy link
Contributor Author

LGTM, I'm not sure though how much more logic should go into seeds before we properly do migrations of seeded data.

I was thinking the same... I feel like switching from just seeding to properly migrate the queries like any other schema change seems like the safer option.

@Kidswiss Kidswiss merged commit 7c97cd4 into master Mar 10, 2023
@Kidswiss Kidswiss deleted the add/redis branch March 10, 2023 08:49
@bastjan
Copy link
Contributor

bastjan commented Mar 10, 2023

I was thinking the same... I feel like switching from just seeding to properly migrate the queries like any other schema change seems like the safer option.

It was never designed for this kinda flexibility. I think we might need to sit together and brainstorm what we would need from such a system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glrf glrf glrf approved these changes

@bastjan bastjan bastjan approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kidswiss @bastjan @glrf