Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement UpgradeSuspensionWindow #88

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Implement UpgradeSuspensionWindow #88

merged 1 commit into from
Jun 20, 2024

Conversation

bastjan
Copy link
Contributor

@bastjan bastjan commented Jun 19, 2024 •
edited
Loading

Introduces the UpgradeSuspensionWindow CRD to configure windows where no upgrades are done.

See #62 and appuio/openshift4-docs#336 for docs.

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

@bastjan bastjan added the enhancement New feature or request label Jun 19, 2024
@bastjan bastjan linked an issue Jun 19, 2024 that may be closed by this pull request
Allow maintenance blocker time windows #62
Closed
@bastjan bastjan force-pushed the implement-upgradesuspensionwindows branch 2 times, most recently from 050e0bd to 53959c2 Compare June 20, 2024 12:21
@bastjan bastjan marked this pull request as ready for review June 20, 2024 12:24
@bastjan bastjan requested a review from a team as a code owner June 20, 2024 12:24
@bastjan bastjan force-pushed the implement-upgradesuspensionwindows branch from 53959c2 to c2173e8 Compare June 20, 2024 12:29
@bastjan bastjan force-pushed the implement-upgradesuspensionwindows branch from c2173e8 to dba663e Compare June 20, 2024 12:30
DebakelOrakel
DebakelOrakel approved these changes Jun 20, 2024
View reviewed changes
Copy link

@DebakelOrakel DebakelOrakel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, as far as I can tell.

simu
simu approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic LGTM, didn't verify the new tests in detail.

@bastjan bastjan merged commit c473029 into master Jun 20, 2024
3 checks passed
@bastjan bastjan deleted the implement-upgradesuspensionwindows branch June 20, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DebakelOrakel DebakelOrakel DebakelOrakel approved these changes

@simu simu simu approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow maintenance blocker time windows
3 participants
@bastjan @simu @DebakelOrakel