Document UpgradeSuspensionWindow
#336
Conversation
|
|
||
| Matching `UpgradeJob` objects won't start the upgrade during the time window. | ||
| Skipped jobs will be marked as successful with reason skipped. | ||
| Success and finish hooks will be executed as normal. |
There was a problem hiding this comment.
How is it handled currently with start hooks for a noop upgradejob? I assume start and success/finish hooks are all executed, right?
Do we need to ensure that we don't have success/finish hooks that expect certain actions to be executed in a corresponding start hook? I'm thinking about a certain customer's scale-down then scale-up requirements.
There was a problem hiding this comment.
Start, Success, and Finish are all executed for noop jobs.
Skipped jobs would only execute Success and Finish.
The hook would see the reason for Success and Finish and we should extend the script there.
There was a problem hiding this comment.
Ok, just something that we need to be aware of before we roll this out. It introduces a new corner case where only some of the hooks are executed, thereby potentially violating some expectations on the behavior that we had previously.
There was a problem hiding this comment.
Yes. I would not expect too many of those weird jobs though. Since they should™️ be idempotent anyways.
docs/modules/ROOT/pages/references/architecture/upgrade_controller.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Adrian Haas <11636405+haasad@users.noreply.github.com>
Also see appuio/openshift-upgrade-controller#62.